[Merged by Bors] - chore(Algebra/Category/ModuleCat): rename ModuleCat.asHom to ModuleCat.ofHom#19705
Closed
Vierkantor wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - chore(Algebra/Category/ModuleCat): rename ModuleCat.asHom to ModuleCat.ofHom#19705Vierkantor wants to merge 1 commit intomasterfrom
ModuleCat.asHom to ModuleCat.ofHom#19705Vierkantor wants to merge 1 commit intomasterfrom
Conversation
…eCat.ofHom` It seems the choice between `ofHom` and `asHom` is somewhat inconsistent in concrete categories, but `ofHom` wins. In particular, we want to be consistent with the newly refactored `AlgebraCat.ofHom` and the constructor for objects `ModuleCat.of`. I have not touched `asHomLeft` and `asHomRight` since #19511 will replace these with `ofHom` everywhere anyway. As discussed in the comments for #19511.
PR summary 59c35b0017Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
mo271
approved these changes
Dec 3, 2024
Closed
1 task
|
🚀 Pull request has been placed on the maintainer queue by chrisflav. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
…eCat.ofHom` (#19705) As discussed in the comments for #19511. It seems the choice between `ofHom` and `asHom` is somewhat inconsistent in concrete categories, but `ofHom` wins. In particular, we want to be consistent with the newly refactored `AlgebraCat.ofHom` and the constructor for objects `ModuleCat.of`. The choice between `asHom` and `ofHom` was only made a few months ago: #17476. It's a bit unfortunate to go back on something that was deprecated so recently, but I think the result is worth the pain. I have not touched `asHomLeft` and `asHomRight` since #19511 will replace these with `ofHom` everywhere anyway.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
ModuleCat.asHom to ModuleCat.ofHomModuleCat.asHom to ModuleCat.ofHom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the comments for #19511.
It seems the choice between
ofHomandasHomis somewhat inconsistent in concrete categories, butofHomwins. In particular, we want to be consistent with the newly refactoredAlgebraCat.ofHomand the constructor for objectsModuleCat.of.The choice between
asHomandofHomwas only made a few months ago: #17476. It's a bit unfortunate to go back on something that was deprecated so recently, but I think the result is worth the pain.I have not touched
asHomLeftandasHomRightsince #19511 will replace these withofHomeverywhere anyway.