[Merged by Bors] - feat(Algebra/Category/ModuleCat/Basic): remove duplicate ofHom#17476
Closed
[Merged by Bors] - feat(Algebra/Category/ModuleCat/Basic): remove duplicate ofHom#17476
ofHom#17476Conversation
We keep `asHom` and use that throughout, since there seems to be no need to keep both around.
PR summary ed9185159bImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
grunweg
reviewed
Oct 8, 2024
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Member
|
Thanks! bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
ofHomofHom
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
…eCat.ofHom` (#19705) As discussed in the comments for #19511. It seems the choice between `ofHom` and `asHom` is somewhat inconsistent in concrete categories, but `ofHom` wins. In particular, we want to be consistent with the newly refactored `AlgebraCat.ofHom` and the constructor for objects `ModuleCat.of`. The choice between `asHom` and `ofHom` was only made a few months ago: #17476. It's a bit unfortunate to go back on something that was deprecated so recently, but I think the result is worth the pain. I have not touched `asHomLeft` and `asHomRight` since #19511 will replace these with `ofHom` everywhere anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We keep
asHomand use that throughout, since there seems to be no need to keep both around.