Skip to content

[Merged by Bors] - feat(check-yaml,yaml-check): various small tweaks#19688

Closed
grunweg wants to merge 3 commits intomasterfrom
MR-tweak-check-yaml
Closed

[Merged by Bors] - feat(check-yaml,yaml-check): various small tweaks#19688
grunweg wants to merge 3 commits intomasterfrom
MR-tweak-check-yaml

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Dec 2, 2024

Extracted from #19634.


Best reviewed commit by commit.

Open in Gitpod

moving the string interpolation into processDb

No behaviour changes; allows tweaking the error message more easily.
@grunweg grunweg added easy < 20s of review time. See the lifecycle page for guidelines. CI Modifies the continuous integration setup or other automation labels Dec 2, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 2, 2024

PR summary 9285ba9820

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@fpvandoorn
Copy link
Copy Markdown
Member

LGTM

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 2, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Dec 2, 2024
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Dec 2, 2024

Thanks for the fast review. CI is green, so let me
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Dec 2, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(check-yaml,yaml-check): various small tweaks [Merged by Bors] - feat(check-yaml,yaml-check): various small tweaks Dec 2, 2024
@mathlib-bors mathlib-bors bot closed this Dec 2, 2024
@mathlib-bors mathlib-bors bot deleted the MR-tweak-check-yaml branch December 2, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants