Skip to content

[Merged by Bors] - feat: add a file tracking results from the 1000+ theorems project#19634

Closed
grunweg wants to merge 6 commits intomasterfrom
MR-1000-theorems
Closed

[Merged by Bors] - feat: add a file tracking results from the 1000+ theorems project#19634
grunweg wants to merge 6 commits intomasterfrom
MR-1000-theorems

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Nov 30, 2024

Add a new file 1000.yaml, tracking the formalisation status of theorems
from the 1000+ theorems project. Make check-yaml handle this file also.

Future PRs will

  • expose this information on the webpage
  • add infrastructure for synchronising this file with the upstream repository
  • could add an attribute similar to the stacks attribute, and generate this file from the tagging
  • add information on existing formalisation projects in Lean.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 30, 2024

PR summary d61e514b58

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Nov 30, 2024
@jsm28
Copy link
Copy Markdown
Contributor

jsm28 commented Nov 30, 2024

The new file seems to be in a random order. Since this project doesn't have a fixed order (theorem 1, theorem 2, ...), I'd suggest sorting it either alphabetically by theorem name (whether by Unicode collation or code-point order) or numerically by Wikidata code. (The 1000-plus data includes MSC codes, and use of those would be reasonable to provide more structure in the list on our website rather than having a purely alphabetical list there, but I'm not sure if sorting by MSC code would make so much sense for this source file.)

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 30, 2024

Good catch! You were right (the old file depended on file system order in some sense); I've added sorting by wikidata ID now.

@fpvandoorn
Copy link
Copy Markdown
Member

Some of the titles contain unicode-escapes, e.g. \u2013.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Dec 2, 2024

Some of the titles contain unicode-escapes, e.g. \u2013.

That's added by the yaml generation script. I'll see if there's an option to output unicode instead.

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 2, 2024
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Dec 2, 2024

Updated and rebased now. This is ready for review again.

@grunweg grunweg removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 2, 2024
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Dec 2, 2024

For cross-reference: 1000-plus/1000-plus.github.io#6 and 1000-plus/1000-plus.github.io#7.

@fpvandoorn
Copy link
Copy Markdown
Member

Thanks!

@fpvandoorn
Copy link
Copy Markdown
Member

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 9, 2024
…9634)

Add a new file `1000.yaml`, tracking the formalisation status of theorems
from the [1000+ theorems project](https://1000-plus.github.io). Make `check-yaml` handle this file also.

Future PRs will
- expose this information on the webpage
- add infrastructure for synchronising this file with the upstream repository
- could add an attribute similar to the `stacks` attribute, and generate this file from the tagging
- add information on existing formalisation projects in Lean.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add a file tracking results from the 1000+ theorems project [Merged by Bors] - feat: add a file tracking results from the 1000+ theorems project Dec 9, 2024
@mathlib-bors mathlib-bors bot closed this Dec 9, 2024
@mathlib-bors mathlib-bors bot deleted the MR-1000-theorems branch December 9, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants