Skip to content

[Merged by Bors] - chore(Mathlib/Algebra/MvPolynomial/Degrees): rename degreeOf_mul_X_eq#19654

Closed
mo271 wants to merge 2 commits intomasterfrom
mo271/rename_degreeOf_mul_X_eq
Closed

[Merged by Bors] - chore(Mathlib/Algebra/MvPolynomial/Degrees): rename degreeOf_mul_X_eq#19654
mo271 wants to merge 2 commits intomasterfrom
mo271/rename_degreeOf_mul_X_eq

Conversation

@mo271
Copy link
Copy Markdown
Collaborator

@mo271 mo271 commented Dec 1, 2024


Open in Gitpod

@mo271
Copy link
Copy Markdown
Collaborator Author

mo271 commented Dec 1, 2024

follow up to #17553

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 1, 2024

PR summary 31ffe80f47

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ degreeOf_mul_X_of_ne
+ degreeOf_mul_X_self

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 1, 2024
@mo271 mo271 removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 2, 2024
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Thanks!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 2, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 2, 2024
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 3, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 3, 2024
…q` (#19654)

Co-authored-by: Moritz Firsching <firsching@google.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Mathlib/Algebra/MvPolynomial/Degrees): rename degreeOf_mul_X_eq [Merged by Bors] - chore(Mathlib/Algebra/MvPolynomial/Degrees): rename degreeOf_mul_X_eq Dec 3, 2024
@mathlib-bors mathlib-bors bot closed this Dec 3, 2024
@mathlib-bors mathlib-bors bot deleted the mo271/rename_degreeOf_mul_X_eq branch December 3, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants