[Merged by Bors] - feat(Algebra/MvPolynomial/Degrees): degreeOf_mul_X_eq_degreeOf_add_one_iff#17553
Closed
[Merged by Bors] - feat(Algebra/MvPolynomial/Degrees): degreeOf_mul_X_eq_degreeOf_add_one_iff#17553
Conversation
Collaborator
mo271
commented
Oct 8, 2024
PR summary cdf3573706Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Collaborator
Author
|
I am a bit confused by the name of the theorem just above this new one: |
vihdzp
reviewed
Oct 17, 2024
Co-authored-by: Violeta Hernández <vi.hdz.p@gmail.com>
Ruben-VandeVelde
approved these changes
Dec 1, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Seems sensible. Agree about renaming the other lemma separately.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 1, 2024
…e_iff (#17553) Co-authored-by: Moritz Firsching <firsching@google.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Collaborator
Author
Renaming done here: #19654 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.