[Merged by Bors] - feat(FieldTheory/SeparableDegree): Field.Emb is infinite for transcendental extension#18770
Closed
[Merged by Bors] - feat(FieldTheory/SeparableDegree): Field.Emb is infinite for transcendental extension#18770
Field.Emb is infinite for transcendental extension#18770Conversation
Field.Emb is infinite for transcendental extension
PR summary f17a842ef8
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.FieldTheory.SeparableDegree | 1421 | 1425 | +4 (+0.28%) |
| Mathlib.FieldTheory.PurelyInseparable | 1435 | 1439 | +4 (+0.28%) |
Import changes for all files
| Files | Import difference |
|---|---|
8 filesMathlib.FieldTheory.IsPerfectClosure Mathlib.FieldTheory.SeparableClosure Mathlib.RingTheory.Unramified.Field Mathlib.FieldTheory.SeparableDegree Mathlib.FieldTheory.Galois.GaloisClosure Mathlib.RingTheory.Etale.Field Mathlib.FieldTheory.Galois.Profinite Mathlib.FieldTheory.PurelyInseparable |
4 |
Declarations diff
+ IsPurelyInseparable.of_injective_comp_algebraMap
+ finSepDegree_eq_zero_of_transcendental
+ infinite_emb_of_transcendental
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
This was referenced Nov 8, 2024
# Conflicts: # Mathlib/FieldTheory/SeparableDegree.lean
Collaborator
|
This PR/issue depends on: |
alreadydone
approved these changes
Nov 15, 2024
Contributor
alreadydone
left a comment
There was a problem hiding this comment.
Thanks, LGTM!
It turns out #9392 is not needed, and Field.embProdEmbOfIsAlgebraic is enough.
Here are some golfs:
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Contributor
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 16, 2024
…endental extension (#18770) - `Field.infinite_emb_of_transcendental`, `Field.finSepDegree_eq_zero_of_transcendental`: `Field.Emb` is infinite and `Field.finSepDegree` is zero for transcendental extensions - remove algebraic assumptions in `isPurelyInseparable_(of|iff)_finSepDegree_eq_one` - prove `IsPurelyInseparable.of_injective_comp_algebraMap` - change `Field.Emb` from `def` to `abbrev`
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Field.Emb is infinite for transcendental extensionField.Emb is infinite for transcendental extension
TobiasLeichtfried
pushed a commit
that referenced
this pull request
Nov 21, 2024
…endental extension (#18770) - `Field.infinite_emb_of_transcendental`, `Field.finSepDegree_eq_zero_of_transcendental`: `Field.Emb` is infinite and `Field.finSepDegree` is zero for transcendental extensions - remove algebraic assumptions in `isPurelyInseparable_(of|iff)_finSepDegree_eq_one` - prove `IsPurelyInseparable.of_injective_comp_algebraMap` - change `Field.Emb` from `def` to `abbrev`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field.infinite_emb_of_transcendental,Field.finSepDegree_eq_zero_of_transcendental:Field.Embis infinite andField.finSepDegreeis zero for transcendental extensionsisPurelyInseparable_(of|iff)_finSepDegree_eq_oneIsPurelyInseparable.of_injective_comp_algebraMapField.EmbfromdeftoabbrevAlgebraicIndependent.aevalEquivFieldand other results #18648Algebra.IsAlgebraic.[of_]ringHom_of_comp_eqandiffversion #18769