[Merged by Bors] - feat(RingTheory/Algebraic): add Algebra.IsAlgebraic.[of_]ringHom_of_comp_eq and iff version#18769
Closed
[Merged by Bors] - feat(RingTheory/Algebraic): add Algebra.IsAlgebraic.[of_]ringHom_of_comp_eq and iff version#18769
Algebra.IsAlgebraic.[of_]ringHom_of_comp_eq and iff version#18769Conversation
PR summary 8f330a72bbImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
2 tasks
Member
|
Thanks! |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 9, 2024
…comp_eq` and `iff` version (#18769) ... parallel to element-wise `IsAlgebraic.[of_]ringHom_of_comp_eq`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Algebra.IsAlgebraic.[of_]ringHom_of_comp_eq and iff versionAlgebra.IsAlgebraic.[of_]ringHom_of_comp_eq and iff version
alreadydone
reviewed
Nov 9, 2024
|
|
||
| theorem IsAlgebraic.ringHom_of_comp_eq (halg : IsAlgebraic R a) | ||
| (hf : Function.Injective f) | ||
| (h : RingHom.comp (algebraMap S B) f = RingHom.comp g (algebraMap R A)) : |
Contributor
There was a problem hiding this comment.
You can write
Suggested change
| (h : RingHom.comp (algebraMap S B) f = RingHom.comp g (algebraMap R A)) : | |
| (h : (algebraMap S B).comp f = RingHom.comp g (algebraMap R A)) : |
and elsewhere.
Collaborator
Author
There was a problem hiding this comment.
Note that f and g are only in RingHomClass, so here I'm extra cautious on using dot notations.
Contributor
There was a problem hiding this comment.
Yeah, but algebraMap _ _ is always a RingHom. I wonder whether (algebraMap R A).comp g works on the RHS; if yes that would be super confusing ...
TobiasLeichtfried
pushed a commit
that referenced
this pull request
Nov 21, 2024
…comp_eq` and `iff` version (#18769) ... parallel to element-wise `IsAlgebraic.[of_]ringHom_of_comp_eq`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... parallel to element-wise
IsAlgebraic.[of_]ringHom_of_comp_eq.