Skip to content

[Merged by Bors] - doc: update README.md instructions for building documentation locally#18713

Closed
dwrensha wants to merge 1 commit intomasterfrom
building-html-documentation-readme
Closed

[Merged by Bors] - doc: update README.md instructions for building documentation locally#18713
dwrensha wants to merge 1 commit intomasterfrom
building-html-documentation-readme

Conversation

@dwrensha
Copy link
Copy Markdown
Member

@dwrensha dwrensha commented Nov 7, 2024

Since #14229, the current instructions in README.md for building docs no longer work.

This PR updates the instructions to refer to the mathlib4_docs repo, which is discussed in
this zulip thread.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 7, 2024

PR summary 7c06df6362

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I haven't tested this locally. This appears to match the zulip thread, though. Can somebody else please confirm these instructions?
maintainer merge?

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 25, 2024
@dwrensha
Copy link
Copy Markdown
Member Author

Can somebody else please confirm these instructions?
I tested them myself again right now and they worked.

The mathlib4_docs Github Action sets its lean-toolchain in the same way:

https://github.com/leanprover-community/mathlib4_docs/blob/64a7d1e6e57b48e1cfbc128be71b0f5feda6dd3f/.github/workflows/docs.yaml#L63

Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 28, 2024
…#18713)

Since #14229, the current instructions in README.md for building docs no longer work.

This PR updates the instructions to refer to the `mathlib4_docs` repo, which is discussed in
[this zulip thread](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/How.20does.20build.20.26.20deploy.20document.20for.20Mathlib4.20currently.3F/near/476591680).
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc: update README.md instructions for building documentation locally [Merged by Bors] - doc: update README.md instructions for building documentation locally Nov 28, 2024
@mathlib-bors mathlib-bors bot closed this Nov 28, 2024
@mathlib-bors mathlib-bors bot deleted the building-html-documentation-readme branch November 28, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants