[Merged by Bors] - chore: remove conditional dependency on doc-gen#14229
Closed
[Merged by Bors] - chore: remove conditional dependency on doc-gen#14229
Conversation
PR summary ab9e19f782Import changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Member
|
LGTM bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 29, 2024
Mathlib's documentation generation CI uses a downstream repository, which just has a conventional `require` on both Mathlib and docgen. As far as I'm aware (please correct me!) this isn't actually needed by anyone. We are very keen to get rid of `meta if`, move to `lakefile.toml`s, and avoid instructing users to ever use `lake -R`. If this change works, I hope that the downstream mathematical repositories that are also using docgen can all follow suit.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
Mathlib's documentation generation CI uses a downstream repository, which just has a conventional `require` on both Mathlib and docgen. As far as I'm aware (please correct me!) this isn't actually needed by anyone. We are very keen to get rid of `meta if`, move to `lakefile.toml`s, and avoid instructing users to ever use `lake -R`. If this change works, I hope that the downstream mathematical repositories that are also using docgen can all follow suit.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
…#18713) Since #14229, the current instructions in README.md for building docs no longer work. This PR updates the instructions to refer to the `mathlib4_docs` repo, which is discussed in [this zulip thread](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/How.20does.20build.20.26.20deploy.20document.20for.20Mathlib4.20currently.3F/near/476591680).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mathlib's documentation generation CI uses a downstream repository, which just has a conventional
requireon both Mathlib and docgen.As far as I'm aware (please correct me!) this isn't actually needed by anyone.
We are very keen to get rid of
meta if, move tolakefile.tomls, and avoid instructing users to ever uselake -R.If this change works, I hope that the downstream mathematical repositories that are also using docgen can all follow suit.