Skip to content

[Merged by Bors] - feat(Topology/Group): continuous isomorphism#16991

Closed
Thmoas-Guan wants to merge 82 commits intomasterfrom
continuous-isomorphism
Closed

[Merged by Bors] - feat(Topology/Group): continuous isomorphism#16991
Thmoas-Guan wants to merge 82 commits intomasterfrom
continuous-isomorphism

Conversation

@Thmoas-Guan
Copy link
Copy Markdown
Collaborator

@Thmoas-Guan Thmoas-Guan commented Sep 21, 2024

Define the continuous isomorphisms of multiplicative and additive topological group.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 21, 2024

PR summary 4656ab5736

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ContinuousAddEquiv
+ ContinuousMulEquiv
+ apply_eq_iff_eq
+ apply_eq_iff_symm_apply
+ apply_symm_apply
+ bijective
+ coe_mk
+ coe_mk'
+ coe_refl
+ coe_toHomeomorph_symm
+ coe_trans
+ comp_symm_eq
+ eq_comp_symm
+ eq_symm_apply
+ eq_symm_comp
+ equivLike_inv_eq_symm
+ ext
+ injective
+ instance : EquivLike (M ≃ₜ* N) M N
+ instance : HomeomorphClass (M ≃ₜ* N) M N
+ instance : Inhabited (M ≃ₜ* M) := ⟨ContinuousMulEquiv.refl M⟩
+ instance : MulEquivClass (M ≃ₜ* N) M N
+ instance {M N} [Unique M] [Unique N] [Mul M] [Mul N]
+ invFun_eq_symm
+ mk'
+ ofUnique
+ refl
+ refl_apply
+ self_comp_symm
+ self_trans_symm
+ surjective
+ symm
+ symm_apply_apply
+ symm_apply_eq
+ symm_comp_eq
+ symm_comp_self
+ symm_symm
+ symm_trans_apply
+ symm_trans_self
+ toEquiv_eq_coe
+ toHomeomorph_eq_coe
+ toMulEquiv_eq_coe
+ trans
+ trans_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Ruben-VandeVelde
Copy link
Copy Markdown
Contributor

Can you please follow the structure from #16908 and #16867?

@Thmoas-Guan Thmoas-Guan added t-topology Topological spaces, uniform spaces, metric spaces, filters t-algebra Algebra (groups, rings, fields, etc) WIP Work in progress labels Sep 23, 2024
@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 21, 2024
and use correct notation in def
@grunweg grunweg changed the title feat(Topology/Group): Continuous isomorphism feat(Topology/Group): continuous isomorphism Dec 22, 2024
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
@kbuzzard kbuzzard added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 23, 2024
@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 23, 2024
@kbuzzard
Copy link
Copy Markdown
Member

I'm happy with this now -- @urkud are you?

@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 28, 2024
Thmoas-Guan and others added 7 commits December 28, 2024 20:09
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 28, 2024
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 2, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 2, 2025
Define the continuous isomorphisms of multiplicative and additive topological group.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 2, 2025

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@mathlib-bors mathlib-bors bot changed the title feat(Topology/Group): continuous isomorphism [Merged by Bors] - feat(Topology/Group): continuous isomorphism Jan 2, 2025
@mathlib-bors mathlib-bors bot closed this Jan 2, 2025
@mathlib-bors mathlib-bors bot deleted the continuous-isomorphism branch January 2, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants