[Merged by Bors] - chore: reorganize RingEquiv declarations#16908
Closed
Ruben-VandeVelde wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - chore: reorganize RingEquiv declarations#16908Ruben-VandeVelde wants to merge 2 commits intomasterfrom
Ruben-VandeVelde wants to merge 2 commits intomasterfrom
Conversation
The API for the various `*Equiv` types is inconsistent both in what results are exposed and how they are organized. Previously, in #16867, we started improving the latter, by organizing results into sections for `Mul/AddEquiv` and `AlgEquiv`, and putting the same results in the same order within those. This PR updates RingEquiv to follow the same structure.
PR summary 0dfe4d448aImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
Contributor
|
✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 21, 2024
The API for the various `*Equiv` types is inconsistent both in what results are exposed and how they are organized. Previously, in #16867, we started improving the latter, by organizing results into sections for `Mul/AddEquiv` and `AlgEquiv`, and putting the same results in the same order within those. This PR updates RingEquiv to follow the same structure.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API for the various
*Equivtypes is inconsistent both in what results are exposed and how they are organized. Previously, in #16867, we started improving the latter, by organizing results into sections forMul/AddEquivandAlgEquiv, and putting the same results in the same order within those. This PR updates RingEquiv to follow the same structure.