[Merged by Bors] - fix(scripts/update_nolints_CI.sh): add missing quote#16806
Closed
bryangingechen wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - fix(scripts/update_nolints_CI.sh): add missing quote#16806bryangingechen wants to merge 1 commit intomasterfrom
bryangingechen wants to merge 1 commit intomasterfrom
Conversation
PR summary 7d735893d6Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
Contributor
|
It's so surprising how blind I feel with CI that such very minor mishaps can get by and it is so hard to figure out what is going on! Thanks! maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by adomani. |
Member
|
Thanks! 🎉 |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 15, 2024
This was missed in the review of #16417 and has been causing the update nolints job to [fail](https://github.com/leanprover-community/mathlib4/actions/runs/10755388285/job/29827004999#step:12:13).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missed in the review of #16417 and has been causing the update nolints job to fail.