[Merged by Bors] - chore: remove style-exceptions.txt#16417
Closed
[Merged by Bors] - chore: remove style-exceptions.txt#16417
style-exceptions.txt#16417Conversation
PR summary e0559f468bImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
6f8390d to
8c56300
Compare
92e3842 to
16c188d
Compare
Contributor
|
How confident are we that we won't need to add new transient exceptions for new linters in the future? Or is the idea that they will also be tracked with The code otherwise looks like it does what it claims to (but admittedly this is my first time looking at the lean4 style linter code). |
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Contributor
Author
That's the right question to ask. Personally, I am willing to make a bet that
|
Contributor
|
I agree with @grunweg, currently it is quite common that a new linter lives in a PR until most of the things it marks have been addressed, which is a good habit. And the PR description now provides good reasoning about future exemptions I think it's safe to remove the file and drop one more technical depth. maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by joneugster. |
Member
|
Thanks! 🎉 |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
This file has been recording exceptions to the text-based style linters in `lint-style.py` and `Linter/TextBased`. The length of this file is meant to reach zero - and now, it indeed has. 🎉 Some of the linter errors were easy to fix (and just required sustained effort), such as some misformatted author lines or missing module documentation. The main remaining entries were exceptions for the "long file linter", which has been rewritten as a syntax linter (in #15610 and #16299). Exceptions are now tracked as `set_option linter.style.longFile <number>` instead, obviating the need for this file. This implies the need for a file with transient style exceptions is gone. All of the remaining text-based linters should not be introduced in new code. For *permanent* exceptions, the file `nolints-style.txt` continues to exist; that file must (intentionally) be updated by hand. [zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/RFC.3A.20remove.20.60scripts.2Fstyle-exceptions.2Etxt.60)
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
This file has been recording exceptions to the text-based style linters in `lint-style.py` and `Linter/TextBased`. The length of this file is meant to reach zero - and now, it indeed has. 🎉 Some of the linter errors were easy to fix (and just required sustained effort), such as some misformatted author lines or missing module documentation. The main remaining entries were exceptions for the "long file linter", which has been rewritten as a syntax linter (in #15610 and #16299). Exceptions are now tracked as `set_option linter.style.longFile <number>` instead, obviating the need for this file. This implies the need for a file with transient style exceptions is gone. All of the remaining text-based linters should not be introduced in new code. For *permanent* exceptions, the file `nolints-style.txt` continues to exist; that file must (intentionally) be updated by hand. [zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/RFC.3A.20remove.20.60scripts.2Fstyle-exceptions.2Etxt.60)
Contributor
|
Pull request successfully merged into master. Build succeeded: |
style-exceptions.txtstyle-exceptions.txt
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
This file has been recording exceptions to the text-based style linters in `lint-style.py` and `Linter/TextBased`. The length of this file is meant to reach zero - and now, it indeed has. 🎉 Some of the linter errors were easy to fix (and just required sustained effort), such as some misformatted author lines or missing module documentation. The main remaining entries were exceptions for the "long file linter", which has been rewritten as a syntax linter (in #15610 and #16299). Exceptions are now tracked as `set_option linter.style.longFile <number>` instead, obviating the need for this file. This implies the need for a file with transient style exceptions is gone. All of the remaining text-based linters should not be introduced in new code. For *permanent* exceptions, the file `nolints-style.txt` continues to exist; that file must (intentionally) be updated by hand. [zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/RFC.3A.20remove.20.60scripts.2Fstyle-exceptions.2Etxt.60)
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
This file has been recording exceptions to the text-based style linters in `lint-style.py` and `Linter/TextBased`. The length of this file is meant to reach zero - and now, it indeed has. 🎉 Some of the linter errors were easy to fix (and just required sustained effort), such as some misformatted author lines or missing module documentation. The main remaining entries were exceptions for the "long file linter", which has been rewritten as a syntax linter (in #15610 and #16299). Exceptions are now tracked as `set_option linter.style.longFile <number>` instead, obviating the need for this file. This implies the need for a file with transient style exceptions is gone. All of the remaining text-based linters should not be introduced in new code. For *permanent* exceptions, the file `nolints-style.txt` continues to exist; that file must (intentionally) be updated by hand. [zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/RFC.3A.20remove.20.60scripts.2Fstyle-exceptions.2Etxt.60)
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
This file has been recording exceptions to the text-based style linters in `lint-style.py` and `Linter/TextBased`. The length of this file is meant to reach zero - and now, it indeed has. 🎉 Some of the linter errors were easy to fix (and just required sustained effort), such as some misformatted author lines or missing module documentation. The main remaining entries were exceptions for the "long file linter", which has been rewritten as a syntax linter (in #15610 and #16299). Exceptions are now tracked as `set_option linter.style.longFile <number>` instead, obviating the need for this file. This implies the need for a file with transient style exceptions is gone. All of the remaining text-based linters should not be introduced in new code. For *permanent* exceptions, the file `nolints-style.txt` continues to exist; that file must (intentionally) be updated by hand. [zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/RFC.3A.20remove.20.60scripts.2Fstyle-exceptions.2Etxt.60)
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 15, 2024
This was missed in the review of #16417 and has been causing the update nolints job to [fail](https://github.com/leanprover-community/mathlib4/actions/runs/10755388285/job/29827004999#step:12:13).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file has been recording exceptions to the text-based style linters in
lint-style.pyandLinter/TextBased. The length of this file is meant to reach zero - and now, it indeed has. 🎉Some of the linter errors were easy to fix (and just required sustained effort), such as some misformatted author lines or missing module documentation. The main remaining entries were exceptions for the "long file linter", which has been rewritten as a syntax linter (in #15610 and #16299). Exceptions are now tracked as
set_option linter.style.longFile <number>instead, obviating the need for this file.This implies the need for a file with transient style exceptions is gone. All of the remaining text-based linters should not be introduced in new code. For permanent exceptions, the file
nolints-style.txtcontinues to exist; that file must (intentionally) be updated by hand.zulip discussion