Skip to content

[Merged by Bors] - feat(Data/ENNReal/Real): add lemmas about iInf, iSup#16770

Closed
mariainesdff wants to merge 4 commits intomasterfrom
mariainesdff/ennreal_real
Closed

[Merged by Bors] - feat(Data/ENNReal/Real): add lemmas about iInf, iSup#16770
mariainesdff wants to merge 4 commits intomasterfrom
mariainesdff/ennreal_real

Conversation

@mariainesdff
Copy link
Copy Markdown
Contributor

Used in #15373.


Open in Gitpod

@mariainesdff mariainesdff added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-analysis Analysis (normed *, calculus) labels Sep 13, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 13, 2024

PR summary 9f80e920c7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ iInf_mul_iInf
+ le_iInf_mul_iInf

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Sep 13, 2024
@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 13, 2024
@D-Thomine
Copy link
Copy Markdown
Collaborator

D-Thomine commented Sep 16, 2024

In le_iInf_mul_iInf and iInf_mul_le_mul_iInf, it seems that the hypotheses (hu_top : ∀ x, u x ≠ ⊤) and (hv_top : ∀ x, v x ≠ ⊤) could use existential quantifiers instead of universal quantifiers. Basically, the idea is that you want to avoid e.g. f infinite everywhere and g converging to 0, in which case H is vacuous but the conclusion is too strong. But existential quantifiers are enough to guarantee that neither f nor g are infinite everywhere.

Is this something you could prove instead?

@D-Thomine
Copy link
Copy Markdown
Collaborator

D-Thomine commented Sep 16, 2024

On a side note: some time ago, we added things like EReal.add_iInf_le_iInf_add. Given that (EReal, +) is isomorphic to (ENNReal, *) through the exponential, you may easily get some similar statements.

Edit: I think this suggestion is worth considering. On the dependent PR, you are proving limsup_mul_le', which is a multiplicative version of EReal.limsup_add_le_add_limsup. You might avoid a lot of work and prove a more general statement that way.

It would also be useful to keep similar names for such statements.

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Oct 2, 2024
@mariainesdff
Copy link
Copy Markdown
Contributor Author

Is this something you could prove instead?

This version is sufficient for my use case, but if you have formalized the more general version I would have no problem changing it.

@mariainesdff mariainesdff removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 2, 2024
@YaelDillies YaelDillies force-pushed the mariainesdff/ennreal_real branch 2 times, most recently from 3740b93 to 8b1f0c1 Compare October 2, 2024 21:09
@YaelDillies YaelDillies force-pushed the mariainesdff/ennreal_real branch from 8b1f0c1 to 9e288a8 Compare October 8, 2024 13:44
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 9, 2024
@mariainesdff mariainesdff removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 9, 2024
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have written most of the current content of the PR

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2024

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 9, 2024
@urkud
Copy link
Copy Markdown
Member

urkud commented Oct 9, 2024

Thanks! 🎉
bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 9, 2024
Used in #15373.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/ENNReal/Real): add lemmas about iInf, iSup [Merged by Bors] - feat(Data/ENNReal/Real): add lemmas about iInf, iSup Oct 9, 2024
@mathlib-bors mathlib-bors bot closed this Oct 9, 2024
@mathlib-bors mathlib-bors bot deleted the mariainesdff/ennreal_real branch October 9, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus) t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants