Skip to content

[Merged by Bors] - feat(Analysis.Normed.Ring.Seminorm): add SmoothingSeminorm#15373

Closed
mariainesdff wants to merge 36 commits intomasterfrom
mariainesdff/smoothing_seminorm
Closed

[Merged by Bors] - feat(Analysis.Normed.Ring.Seminorm): add SmoothingSeminorm#15373
mariainesdff wants to merge 36 commits intomasterfrom
mariainesdff/smoothing_seminorm

Conversation

@mariainesdff
Copy link
Copy Markdown
Contributor

@mariainesdff mariainesdff commented Jul 31, 2024

We prove Proposition 1.3.2/1 from S. Bosch, U. Güntzer, R. Remmert, Non-Archimedean Analysis: if f is a nonarchimedean seminorm on R, then iInf (fun n : PNat => (f (x ^ (n : ℕ))) ^ (1 / (n : ℝ))) is a power-multiplicative nonarchimedean seminorm on R.


Open in Gitpod

@mariainesdff mariainesdff added WIP Work in progress awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jul 31, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 31, 2024

PR summary e1af4db594

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Analysis.Normed.Ring.SmoothingSeminorm (new file) 1603

Declarations diff

+ isNonarchimedean_smoothingFun
+ isPowMul_smoothingFun
+ pow_mul_apply_eq_pow_mul
+ smoothingFun
+ smoothingFun_apply_of_map_mul_eq_mul
+ smoothingFun_le
+ smoothingFun_le_self
+ smoothingFun_nonneg
+ smoothingFun_of_map_mul_eq_mul
+ smoothingFun_of_powMul
+ smoothingFun_one_le
+ smoothingSeminorm
+ smoothingSeminormSeq
+ smoothingSeminormSeq_bddBelow
+ smoothingSeminorm_apply_of_map_mul_eq_mul
+ smoothingSeminorm_map_one_le_one
+ smoothingSeminorm_of_mul
+ tendsto_smoothingFun_comp
+ tendsto_smoothingFun_of_eq_zero
+ tendsto_smoothingFun_of_map_one_le_one
+ tendsto_smoothingFun_of_ne_zero
+ zero_mem_lowerBounds_smoothingSeminormSeq_range

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Aug 1, 2024
@mariainesdff mariainesdff added t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-analysis Analysis (normed *, calculus) and removed WIP Work in progress labels Aug 1, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 4, 2024
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 12, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 16, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 9, 2024
@jcommelin
Copy link
Copy Markdown
Member

This PR is quite large. Are you planning to split it up?

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Sep 13, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 9, 2024
Used in #15373.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
mathlib-bors bot pushed a commit that referenced this pull request Oct 21, 2024
This PR adds a few lemmas about multiplication and liminf/limsup/iInf/iSup: `mul_iInf_le_iInf_mul`, `iSup_mul_le_mul_iSup`, `mul_liminf_le_liminf_mul` and three avatars of the latter.

The strategy adopted is the same as for similar lemmas in EReal (`EReal.add_iInf_le_iInf_add`...): we suffer to prove the key result `mul_le_of_forall_mul_le`, and everything is deduced from there.

Note that `ENNReal.mul_le_of_forall_mul_le` could be deduced much faster from `EReal.add_le_of_forall_add_le` using the exp (both as an order isomorphism and as a "group" morphism). However, I wanted to avoid importing special functions, which unfortunately leads to a much longer and painful proof.

This also generalizes some lemmas in #15373 : `limsup_mul_le'` therein can be replaced by `limsup_mul_le_mul_limsup` with some easy plug-and-play; if `_root_.Real.limsup_mul_le` is still needed, I can write another PR to deal with it (most of the work is already done anyways -- I think I can prove `mul_le_of_forall_mul_le` in NNReal, and leverage it to simplify the proof in ENNReal).



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@faenuccio
Copy link
Copy Markdown
Contributor

I left some answers to your comments, I'll now check the remaining sections.

Copy link
Copy Markdown
Contributor

@faenuccio faenuccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some other comment.

@faenuccio
Copy link
Copy Markdown
Contributor

Thanks for all the work, LGTM!

@faenuccio
Copy link
Copy Markdown
Contributor

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2025

🚀 Pull request has been placed on the maintainer queue by faenuccio.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 5, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Otherwise LGTM

bors d+

Comment on lines +612 to +613
theorem pow_mul_apply_eq_pow_mul {R : Type*} [MonoidWithZero R] (f : R → ℝ) {x : R}
(hx : ∀ y : R, f (x * y) = f x * f y) : ∀ (n : ℕ) (y : R), f (x ^ n * y) = f x ^ n * f y := by
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
theorem pow_mul_apply_eq_pow_mul {R : Type*} [MonoidWithZero R] (f : R → ℝ) {x : R}
(hx : ∀ y : R, f (x * y) = f x * f y) : ∀ (n : ℕ) (y : R), f (x ^ n * y) = f x ^ n * f y := by
theorem pow_mul_apply_eq_pow_mul {R : Type*} [MonoidWithZero R] (f : R → ℝ) {x : R}
(hx : ∀ y : R, f (x * y) = f x * f y) (n : ℕ) : ∀ (y : R), f (x ^ n * y) = f x ^ n * f y := by

then you can drop the intro n.

Also, this doesn't use anything about the real numbers, right? So the target of f could be any type with a multiplication, I guess. And then it could move to a basic algebra file.

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 7, 2025

✌️ mariainesdff can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Feb 7, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 7, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 7, 2025
We prove Proposition 1.3.2/1 from S. Bosch, U. Güntzer, R. Remmert, *Non-Archimedean Analysis*: if `f` is a nonarchimedean seminorm on `R`, then `iInf (fun n : PNat => (f (x ^ (n : ℕ))) ^ (1 / (n : ℝ)))` is a power-multiplicative nonarchimedean seminorm on `R`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 7, 2025

Build failed (retrying...):

@bryangingechen
Copy link
Copy Markdown
Contributor

bors r-

Please merge master, fix the build and place back on the queue by commenting bors merge. Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 7, 2025

Canceled.

@mariainesdff
Copy link
Copy Markdown
Contributor Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 10, 2025
We prove Proposition 1.3.2/1 from S. Bosch, U. Güntzer, R. Remmert, *Non-Archimedean Analysis*: if `f` is a nonarchimedean seminorm on `R`, then `iInf (fun n : PNat => (f (x ^ (n : ℕ))) ^ (1 / (n : ℝ)))` is a power-multiplicative nonarchimedean seminorm on `R`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 10, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Analysis.Normed.Ring.Seminorm): add SmoothingSeminorm [Merged by Bors] - feat(Analysis.Normed.Ring.Seminorm): add SmoothingSeminorm Feb 10, 2025
@mathlib-bors mathlib-bors bot closed this Feb 10, 2025
@mathlib-bors mathlib-bors bot deleted the mariainesdff/smoothing_seminorm branch February 10, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants