[Merged by Bors] - fix(*.yml): robustify checks for line endings#16456
Closed
bryangingechen wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - fix(*.yml): robustify checks for line endings#16456bryangingechen wants to merge 4 commits intomasterfrom
bryangingechen wants to merge 4 commits intomasterfrom
Conversation
…d test of github.event.issue.pull_request
Specifically, check for \n instead of \r\n when scanning for "bors merge" / "bors r+" / "bors d" and split lines in labels_from_comment.yml with a regex that allows for both \r\n and \n.
PR summary 0a903f2e9dImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
grunweg
reviewed
Sep 3, 2024
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Thanks! I haven't checked the regex carefully, but it looks plausible: the other changes look good to me.
maintainer delegate, i.e. feel free to maintainer merge on my behalf once the dependent PR has landed.
Contributor
|
bors d+ |
Contributor
|
✌️ bryangingechen can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
|
This PR/issue depends on: |
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
Currently the bots sometimes end up failing to apply the `ready to merge` label due to this, see e.g. [this comment](#16452 (comment)) and [the corresponding run](https://github.com/leanprover-community/mathlib4/actions/runs/10685754793). The underlying issue is probably the same as that was causing ghost maintainer merges which was fixed in #14663, so I've applied the same change to the remaining workflow files where this was a potential issue. I found one other place in labels_from_comment.yml which was relying on line endings being `\r\n` so I've fixed that by using a regex that allows for both `\r\n` and `\n`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
Currently the bots sometimes end up failing to apply the `ready to merge` label due to this, see e.g. [this comment](#16452 (comment)) and [the corresponding run](https://github.com/leanprover-community/mathlib4/actions/runs/10685754793). The underlying issue is probably the same as that was causing ghost maintainer merges which was fixed in #14663, so I've applied the same change to the remaining workflow files where this was a potential issue. I found one other place in labels_from_comment.yml which was relying on line endings being `\r\n` so I've fixed that by using a regex that allows for both `\r\n` and `\n`.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
Currently the bots sometimes end up failing to apply the `ready to merge` label due to this, see e.g. [this comment](#16452 (comment)) and [the corresponding run](https://github.com/leanprover-community/mathlib4/actions/runs/10685754793). The underlying issue is probably the same as that was causing ghost maintainer merges which was fixed in #14663, so I've applied the same change to the remaining workflow files where this was a potential issue. I found one other place in labels_from_comment.yml which was relying on line endings being `\r\n` so I've fixed that by using a regex that allows for both `\r\n` and `\n`.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
Currently the bots sometimes end up failing to apply the `ready to merge` label due to this, see e.g. [this comment](#16452 (comment)) and [the corresponding run](https://github.com/leanprover-community/mathlib4/actions/runs/10685754793). The underlying issue is probably the same as that was causing ghost maintainer merges which was fixed in #14663, so I've applied the same change to the remaining workflow files where this was a potential issue. I found one other place in labels_from_comment.yml which was relying on line endings being `\r\n` so I've fixed that by using a regex that allows for both `\r\n` and `\n`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the bots sometimes end up failing to apply the
ready to mergelabel due to this, see e.g. this comment and the corresponding run.The underlying issue is probably the same as that was causing ghost maintainer merges which was fixed in #14663, so I've applied the same change to the remaining workflow files where this was a potential issue.
I found one other place in labels_from_comment.yml which was relying on line endings being
\r\nso I've fixed that by using a regex that allows for both\r\nand\n.