[Merged by Bors] - fix(*_comment.yml): fix uses of github.event.issue.pull_request#16241
Closed
bryangingechen wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - fix(*_comment.yml): fix uses of github.event.issue.pull_request#16241bryangingechen wants to merge 2 commits intomasterfrom
bryangingechen wants to merge 2 commits intomasterfrom
Conversation
…d test of github.event.issue.pull_request
PR summary bccd4d4ef2Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
1 task
be4ed72 to
bccd4d4
Compare
1 task
Contributor
|
I checked the documentation: this change makes sense. Thanks for correcting this! |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
In our Github actions workflows which react to comments, there were several instances of `github.event.issue.pull_request != null` to check whether the comment was posted on a PR. However, this always returns `true`, so these workflows could in principle be triggered to run by someone writing comments on issues rather than PRs. The [Github actions documentation](https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#issue_comment-on-issues-only-or-pull-requests-only) suggests just using `github.event.issue.pull_request` in conditionals, so I've replaced the incorrect tests with that. There was also a usage of `toJSON(github.event.issue.pull_request) != null` which even if correct is overcomplicated, so I fixed that as well.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
In our Github actions workflows which react to comments, there were several instances of `github.event.issue.pull_request != null` to check whether the comment was posted on a PR. However, this always returns `true`, so these workflows could in principle be triggered to run by someone writing comments on issues rather than PRs. The [Github actions documentation](https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#issue_comment-on-issues-only-or-pull-requests-only) suggests just using `github.event.issue.pull_request` in conditionals, so I've replaced the incorrect tests with that. There was also a usage of `toJSON(github.event.issue.pull_request) != null` which even if correct is overcomplicated, so I fixed that as well.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
In our Github actions workflows which react to comments, there were several instances of `github.event.issue.pull_request != null` to check whether the comment was posted on a PR. However, this always returns `true`, so these workflows could in principle be triggered to run by someone writing comments on issues rather than PRs. The [Github actions documentation](https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#issue_comment-on-issues-only-or-pull-requests-only) suggests just using `github.event.issue.pull_request` in conditionals, so I've replaced the incorrect tests with that. There was also a usage of `toJSON(github.event.issue.pull_request) != null` which even if correct is overcomplicated, so I fixed that as well.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
In our Github actions workflows which react to comments, there were several instances of `github.event.issue.pull_request != null` to check whether the comment was posted on a PR. However, this always returns `true`, so these workflows could in principle be triggered to run by someone writing comments on issues rather than PRs. The [Github actions documentation](https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#issue_comment-on-issues-only-or-pull-requests-only) suggests just using `github.event.issue.pull_request` in conditionals, so I've replaced the incorrect tests with that. There was also a usage of `toJSON(github.event.issue.pull_request) != null` which even if correct is overcomplicated, so I fixed that as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our Github actions workflows which react to comments, there were several instances of
github.event.issue.pull_request != nullto check whether the comment was posted on a PR. However, this always returnstrue, so these workflows could in principle be triggered to run by someone writing comments on issues rather than PRs.The Github actions documentation suggests just using
github.event.issue.pull_requestin conditionals, so I've replaced the incorrect tests with that.There was also a usage of
toJSON(github.event.issue.pull_request) != nullwhich even if correct is overcomplicated, so I fixed that as well.Follow-up to #15781 (comment)