[Merged by Bors] - feat(Data/List/Sigma): Lemmas relating List.dlookup and List.append#15951
Closed
[Merged by Bors] - feat(Data/List/Sigma): Lemmas relating List.dlookup and List.append#15951
List.dlookup and List.append#15951Conversation
PR summary a1862bb66fImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
dlookup and appendList.dlookup and List.append
eric-wieser
reviewed
Aug 19, 2024
eric-wieser
approved these changes
Aug 21, 2024
Member
eric-wieser
left a comment
There was a problem hiding this comment.
I pushed some tweaks, from least to most opinionated:
- Arguments to lemmas about
=are usually explicit inductionis now preferred toinduction'iteratemakes the proof a little harder to inspect, andrflis usually worse than finding the right lemma if you're already using other lemmasDecidable.eq_or_nesaves needingClassical.choice, but no one really cares
Feel free to revert either of the last two if you disagree with them
bors d+
Contributor
|
✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
Author
|
I like this statement a lot better. bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
…d` (#15951) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
List.dlookup and List.appendList.dlookup and List.append
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
…d` (#15951) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
…d` (#15951) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
…d` (#15951) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conflicts with #15928 but can be merged in any order.
Both of these lemmas are used in my development of the Cantor normal form.