Skip to content

[Merged by Bors] - feat(Data/List/Sigma): Lemmas relating List.dlookup and List.map#15928

Closed
vihdzp wants to merge 3 commits intomasterfrom
vi.dlookup_map
Closed

[Merged by Bors] - feat(Data/List/Sigma): Lemmas relating List.dlookup and List.map#15928
vihdzp wants to merge 3 commits intomasterfrom
vi.dlookup_map

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Aug 18, 2024 •
edited
Loading

Conflicts with #15951 but can be merged in either order.

These are admittedly very specific results, but I make use of dlookup_map₁ in an upcoming PR.

I don't know if dependent versions of these can exist.

Open in Gitpod

@vihdzp vihdzp added the t-data Data (lists, quotients, numbers, etc) label Aug 18, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 18, 2024 •
edited
Loading

PR summary 554243f848

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ dlookup_map
+ dlookup_map₁
+ dlookup_map₂

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@vihdzp vihdzp mentioned this pull request Aug 18, 2024
Closed
eric-wieser
eric-wieser reviewed Aug 19, 2024
View reviewed changes
@eric-wieser
Copy link
Copy Markdown
Member

eric-wieser commented Aug 21, 2024

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 21, 2024

🚀 Pull request has been placed on the maintainer queue by eric-wieser.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 21, 2024
jcommelin
jcommelin reviewed Aug 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Aug 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 23, 2024
@vihdzp @eric-wieser
feat(Data/List/Sigma): Lemmas relating List.dlookup and List.map (#…
3f803c4 
…15928)

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/List/Sigma): Lemmas relating List.dlookup and List.map [Merged by Bors] - feat(Data/List/Sigma): Lemmas relating List.dlookup and List.map Aug 23, 2024
@mathlib-bors mathlib-bors bot closed this Aug 23, 2024
@mathlib-bors mathlib-bors bot deleted the vi.dlookup_map branch August 23, 2024 15:37
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
@vihdzp @eric-wieser @bjoernkjoshanssen
feat(Data/List/Sigma): Lemmas relating List.dlookup and List.map (#…
d0bdb2d 
…15928)

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
@vihdzp @eric-wieser @bjoernkjoshanssen
feat(Data/List/Sigma): Lemmas relating List.dlookup and List.map (#…
7c77085 
…15928)

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
@vihdzp @eric-wieser @bjoernkjoshanssen
feat(Data/List/Sigma): Lemmas relating List.dlookup and List.map (#…
0b0d1cf 
…15928)

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin left review comments

Assignees

No one assigned

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vihdzp @eric-wieser @jcommelin