Skip to content

[Merged by Bors] - feat(Filter/Pointwise): add one_prod and prod_one#15862

Closed
urkud wants to merge 25 commits intomasterfrom
YK-prod-one
Closed

[Merged by Bors] - feat(Filter/Pointwise): add one_prod and prod_one#15862
urkud wants to merge 25 commits intomasterfrom
YK-prod-one

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Aug 16, 2024

Similar lemmas about pure are already in the default simp set.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 16, 2024

PR summary 2147489e08

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ one_prod
+ prod_one

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@urkud urkud added t-topology Topological spaces, uniform spaces, metric spaces, filters t-order Order theory labels Aug 16, 2024
@urkud urkud added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Aug 16, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Aug 16, 2024
@urkud urkud added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 16, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 16, 2024
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 18, 2024
@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 18, 2024
urkud and others added 2 commits August 20, 2024 22:52
Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 21, 2024
@ghost
Copy link
Copy Markdown

ghost commented Aug 21, 2024

This PR/issue depends on:

@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 21, 2024
@urkud urkud added easy < 20s of review time. See the lifecycle page for guidelines. and removed awaiting-author A reviewer has asked the author a question or requested changes. merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Aug 21, 2024
@urkud urkud requested a review from grunweg August 22, 2024 17:04
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 22, 2024
@sgouezel
Copy link
Copy Markdown
Contributor

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 23, 2024
Similar lemmas about `pure` are already in the default `simp` set.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Filter/Pointwise): add one_prod and prod_one [Merged by Bors] - feat(Filter/Pointwise): add one_prod and prod_one Aug 23, 2024
@mathlib-bors mathlib-bors bot closed this Aug 23, 2024
@mathlib-bors mathlib-bors bot deleted the YK-prod-one branch August 23, 2024 06:57
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
Similar lemmas about `pure` are already in the default `simp` set.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
Similar lemmas about `pure` are already in the default `simp` set.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
Similar lemmas about `pure` are already in the default `simp` set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-order Order theory t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants