Skip to content

[Merged by Bors] - chore(Algebra/Prod): add Prod.mk_one_one#15922

Closed
urkud wants to merge 6 commits intomasterfrom
YK-prod-mk-one
Closed

[Merged by Bors] - chore(Algebra/Prod): add Prod.mk_one_one#15922
urkud wants to merge 6 commits intomasterfrom
YK-prod-mk-one

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Aug 17, 2024

  • Normalize (1, 1) and (0, 0) to 1 and 0, respectively.
  • Add Polynomial.mul_coeff_one

Moves:

  • PerfectClosure.mk_zero_zero -> PefectClosure.mk_zero
  • PerfectClosure.mk_zero -> PerfectClosure.mk_zero_right

Open in Gitpod

@urkud urkud added the t-algebra Algebra (groups, rings, fields, etc) label Aug 17, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 17, 2024

PR summary cf676660d7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ mk_one_one
+ mk_zero_right
+ mul_coeff_one

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@urkud urkud added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 19, 2024
urkud and others added 4 commits August 20, 2024 22:52
Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mattrobball
Copy link
Copy Markdown
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Aug 21, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 21, 2024
- Normalize `(1, 1) ` and `(0, 0)` to `1` and `0`, respectively.
- Add `Polynomial.mul_coeff_one`

Moves:
- PerfectClosure.mk_zero_zero -> PefectClosure.mk_zero
- PerfectClosure.mk_zero -> PerfectClosure.mk_zero_right
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 21, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Prod): add Prod.mk_one_one [Merged by Bors] - chore(Algebra/Prod): add Prod.mk_one_one Aug 21, 2024
@mathlib-bors mathlib-bors bot closed this Aug 21, 2024
@mathlib-bors mathlib-bors bot deleted the YK-prod-mk-one branch August 21, 2024 19:39
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
- Normalize `(1, 1) ` and `(0, 0)` to `1` and `0`, respectively.
- Add `Polynomial.mul_coeff_one`

Moves:
- PerfectClosure.mk_zero_zero -> PefectClosure.mk_zero
- PerfectClosure.mk_zero -> PerfectClosure.mk_zero_right
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
- Normalize `(1, 1) ` and `(0, 0)` to `1` and `0`, respectively.
- Add `Polynomial.mul_coeff_one`

Moves:
- PerfectClosure.mk_zero_zero -> PefectClosure.mk_zero
- PerfectClosure.mk_zero -> PerfectClosure.mk_zero_right
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
- Normalize `(1, 1) ` and `(0, 0)` to `1` and `0`, respectively.
- Add `Polynomial.mul_coeff_one`

Moves:
- PerfectClosure.mk_zero_zero -> PefectClosure.mk_zero
- PerfectClosure.mk_zero -> PerfectClosure.mk_zero_right
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants