[Merged by Bors] - chore (GCDMonoid.Nat): avoid bundled ordered algebra and move Init.Data.Int.Order#15152
Closed
mattrobball wants to merge 19 commits intomasterfrom
Closed
[Merged by Bors] - chore (GCDMonoid.Nat): avoid bundled ordered algebra and move Init.Data.Int.Order#15152mattrobball wants to merge 19 commits intomasterfrom
Init.Data.Int.Order#15152mattrobball wants to merge 19 commits intomasterfrom
Conversation
PR summary 7f06929087
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.GCDMonoid.Nat | 413 | 399 | -14 (-3.39%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Init.Data.Int.Order |
-35 |
Mathlib.Algebra.GCDMonoid.Nat |
-14 |
Mathlib.Data.Int.Order.Basic |
35 |
Declarations diff
+ mul_nonneg_iff
+ mul_nonneg_of_nonneg_or_nonpos
+ nonneg_or_nonpos_of_mul_nonneg
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
|
This PR/issue depends on: |
Init.Data.Int.Order
jcommelin
approved these changes
Aug 22, 2024
Member
jcommelin
left a comment
There was a problem hiding this comment.
Thanks 🎉
If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.
bors d+
Contributor
|
✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
…ata.Int.Order` (#15152) We swap out some bundled ordered algebra API calls for native `Nat` and `Int` ones. We also add one. This allows us to avoid needing bundled ordered algebra in this file and pushes its import further downstream. Since it touches `Init.Data.Int.Order`, we rename it `Data.Int.Order.Basic`. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Init.Data.Int.OrderInit.Data.Int.Order
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
…ata.Int.Order` (#15152) We swap out some bundled ordered algebra API calls for native `Nat` and `Int` ones. We also add one. This allows us to avoid needing bundled ordered algebra in this file and pushes its import further downstream. Since it touches `Init.Data.Int.Order`, we rename it `Data.Int.Order.Basic`. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
…ata.Int.Order` (#15152) We swap out some bundled ordered algebra API calls for native `Nat` and `Int` ones. We also add one. This allows us to avoid needing bundled ordered algebra in this file and pushes its import further downstream. Since it touches `Init.Data.Int.Order`, we rename it `Data.Int.Order.Basic`. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
…ata.Int.Order` (#15152) We swap out some bundled ordered algebra API calls for native `Nat` and `Int` ones. We also add one. This allows us to avoid needing bundled ordered algebra in this file and pushes its import further downstream. Since it touches `Init.Data.Int.Order`, we rename it `Data.Int.Order.Basic`. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We swap out some bundled ordered algebra API calls for native
NatandIntones. We also add one. This allows us to avoid needing bundled ordered algebra in this file and pushes its import further downstream. Since it touchesInit.Data.Int.Order, we rename itData.Int.Order.Basic.