[Merged by Bors] - chore (Algebra.Order.Group.Int): split file into unbundled and bundled ordered algebra#15069
Closed
mattrobball wants to merge 9 commits intomasterfrom
Closed
[Merged by Bors] - chore (Algebra.Order.Group.Int): split file into unbundled and bundled ordered algebra#15069mattrobball wants to merge 9 commits intomasterfrom
mattrobball wants to merge 9 commits intomasterfrom
Conversation
PR summary 98c722197d
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Order.Group.Int | 347 | 325 | -22 (-6.34%) |
| Mathlib.Algebra.EuclideanDomain.Int | 379 | 373 | -6 (-1.58%) |
| Mathlib.Algebra.Order.Ring.Int | 392 | 388 | -4 (-1.02%) |
| Mathlib.Data.Int.Interval | 543 | 547 | +4 (+0.74%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Algebra.Order.Group.Int |
-22 |
Mathlib.Algebra.EuclideanDomain.Int |
-6 |
8 filesMathlib.Data.Int.ConditionallyCompleteOrder Mathlib.Data.Int.LeastGreatest Mathlib.Algebra.Order.Ring.Int Mathlib.Testing.SlimCheck.Testable Mathlib.Testing.SlimCheck.Sampleable Mathlib.Data.Int.Range Mathlib.Algebra.Order.Ring.Rat Mathlib.Tactic.SlimCheck |
-4 |
3 filesMathlib.Order.Grade Mathlib.Data.Nat.Cast.SetInterval Mathlib.Data.Int.SuccPred |
-2 |
106 filesMathlib.Tactic.Ring.Basic Mathlib.Data.Nat.Hyperoperation Mathlib.Algebra.Star.Module Mathlib.Data.Matrix.Auto Mathlib.Data.Finset.Interval Mathlib.LinearAlgebra.Finsupp Mathlib.Data.Finset.Grade Mathlib.Data.Finsupp.Basic Mathlib.Tactic.Ring.PNat Mathlib.Data.Matrix.Invertible Mathlib.Tactic.Linarith.Preprocessing Mathlib.CategoryTheory.Monoidal.Linear Mathlib.Data.Matrix.Composition Mathlib.Tactic.LinearCombination Mathlib.Data.Matrix.Basic Mathlib.Data.Matrix.Basis Mathlib.GroupTheory.Coxeter.Matrix Mathlib.LinearAlgebra.DFinsupp Mathlib.Data.Finsupp.Encodable Mathlib.Data.Matrix.PEquiv Mathlib.Algebra.Category.ModuleCat.Monoidal.Symmetric Mathlib.LinearAlgebra.Dimension.Finrank Mathlib.Algebra.Category.ModuleCat.Monoidal.Basic Mathlib.Algebra.MonoidAlgebra.Support Mathlib.Data.Rat.Denumerable Mathlib.RingTheory.Coprime.Lemmas Mathlib.Data.Nat.Fib.Basic Mathlib.Tactic.Polyrith Mathlib.Tactic.Linarith.Frontend Mathlib.Data.Rat.BigOperators Mathlib.Algebra.Algebra.Hom.Rat Mathlib.Data.Matrix.Block Mathlib.Algebra.Order.Ring.Star Mathlib.Algebra.Field.Rat Mathlib.Algebra.Algebra.Unitization Mathlib.Data.Rat.Cast.Defs Mathlib.CategoryTheory.Preadditive.Mat Mathlib.CategoryTheory.Quotient.Linear Mathlib.Algebra.MonoidAlgebra.Degree Mathlib.Combinatorics.SetFamily.Compression.UV Mathlib.Data.Matrix.Reflection Mathlib.Algebra.Ring.Identities Mathlib.Testing.SlimCheck.Functions Mathlib.LinearAlgebra.Dimension.Basic Mathlib.LinearAlgebra.LinearIndependent Mathlib.Tactic.Ring.RingNF Mathlib.Tactic.Linarith.Oracle.FourierMotzkin Mathlib.Algebra.Star.Rat Mathlib.Data.Nat.BitIndices Mathlib.Algebra.Ring.BooleanRing Mathlib.Algebra.Homology.ShortComplex.Linear Mathlib.Data.NNRat.Lemmas Mathlib.Combinatorics.SetFamily.Shadow Mathlib.LinearAlgebra.Matrix.Trace Mathlib.Algebra.Star.Order Mathlib.RepresentationTheory.Action.Monoidal Mathlib.RepresentationTheory.Action.Limits Mathlib.Data.PNat.Xgcd Mathlib.Tactic.NormNum.Inv Mathlib.Data.FP.Basic Mathlib.Algebra.Category.ModuleCat.Monoidal.Closed Mathlib.Tactic.Group Mathlib.Tactic.NormNum.Eq Mathlib.Data.Rat.Cast.Lemmas Mathlib.CategoryTheory.Monoidal.Subcategory Mathlib.Algebra.Star.SelfAdjoint Mathlib.Tactic.Linarith.Parsing Mathlib.Tactic.NormNum.OfScientific Mathlib.Algebra.Order.Field.Rat Mathlib.LinearAlgebra.Matrix.Symmetric Mathlib.Tactic.Linarith.Datatypes Mathlib.Order.Interval.Finset.Box Mathlib.Order.KonigLemma Mathlib.Data.NNRat.Defs Mathlib.Tactic.Linarith.Oracle.SimplexAlgorithm Mathlib.Algebra.ContinuedFractions.Determinant Mathlib.Data.Rat.Cast.CharZero Mathlib.Algebra.Homology.Linear Mathlib.Algebra.MonoidAlgebra.Division Mathlib.Data.Fintype.Perm Mathlib.Tactic.Ring Mathlib.RingTheory.Coprime.Basic Mathlib.Algebra.Polynomial.Monomial Mathlib.Data.Matrix.RowCol Mathlib.Data.Matrix.DualNumber Mathlib.CategoryTheory.Linear.LinearFunctor Mathlib.Data.Finsupp.ToDFinsupp Mathlib.Algebra.Field.Subfield Mathlib.Data.Matrix.Hadamard Mathlib.Data.Nat.Fib.Zeckendorf Mathlib.Algebra.Polynomial.Basic Mathlib.Algebra.Algebra.Field Mathlib.Algebra.Algebra.Rat Mathlib.Algebra.FreeNonUnitalNonAssocAlgebra Mathlib.Algebra.MonoidAlgebra.Basic Mathlib.Data.Finsupp.AList Mathlib.Combinatorics.SimpleGraph.IncMatrix Mathlib.Tactic.Linarith.Verification Mathlib.Algebra.Category.BoolRing Mathlib.Algebra.Module.LinearMap.Rat Mathlib.Algebra.Order.Field.Subfield Mathlib.Data.Matrix.Notation Mathlib.Algebra.Module.Rat Mathlib.Tactic.Bound Mathlib.LinearAlgebra.Matrix.Circulant Mathlib.LinearAlgebra.Matrix.Orthogonal |
-1 |
Mathlib.Data.Int.Interval |
4 |
Mathlib.Algebra.Order.Group.Unbundled.Int |
341 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
1 task
|
This PR/issue depends on: |
1 task
Contributor
|
I'm delegating this in case we want to wait until after the new bors d+ |
Contributor
|
✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
Since this is about a concrete type, |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
…d ordered algebra (#15069) All but ~5 lines of this file did not require bundled ordered algebra classes. We split them off into `Algebra.Order.Group.Unbundled.Int` leaving the `LinearOrderedAddCommGroup` instance.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
…d ordered algebra (#15069) All but ~5 lines of this file did not require bundled ordered algebra classes. We split them off into `Algebra.Order.Group.Unbundled.Int` leaving the `LinearOrderedAddCommGroup` instance.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
…d ordered algebra (#15069) All but ~5 lines of this file did not require bundled ordered algebra classes. We split them off into `Algebra.Order.Group.Unbundled.Int` leaving the `LinearOrderedAddCommGroup` instance.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
…d ordered algebra (#15069) All but ~5 lines of this file did not require bundled ordered algebra classes. We split them off into `Algebra.Order.Group.Unbundled.Int` leaving the `LinearOrderedAddCommGroup` instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All but ~5 lines of this file did not require bundled ordered algebra classes. We split them off into
Algebra.Order.Group.Unbundled.Intleaving theLinearOrderedAddCommGroupinstance.