[Merged by Bors] - chore (Algebra.Order.Group.Abs): split file into unbundled and bundled material #15065
Closed
mattrobball wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - chore (Algebra.Order.Group.Abs): split file into unbundled and bundled material #15065mattrobball wants to merge 3 commits intomasterfrom
mattrobball wants to merge 3 commits intomasterfrom
Conversation
PR summary a51095ac12
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Order.Group.PosPart | 244 | 239 | -5 (-2.05%) |
| Mathlib.Algebra.Group.Subgroup.Order | 410 | 407 | -3 (-0.73%) |
| Mathlib.Algebra.Order.Group.Indicator | 390 | 388 | -2 (-0.51%) |
| Mathlib.Data.Nat.Cast.Order.Ring | 407 | 406 | -1 (-0.25%) |
| Mathlib.RingTheory.Prime | 528 | 527 | -1 (-0.19%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 2720 files with changed transitive imports: this is too many to display! |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
1 task
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
…d material (#15065) Currently `Algebra.Order.Group.Abs` imports `OrderedCommMonoid` and other bundled algebra classes despite much of the file using unbundled ordered algebra typeclasses. We split into `Algebra.Order.Group.Unbundled.Abs` and `Algebra.Order.Group.Abs` to separate the bundled and unbundled parts of the file and minimize imports downstream.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
Algebra.Order.Group.AbsimportsOrderedCommMonoidand other bundled algebra classes despite much of the file using unbundled ordered algebra typeclasses. We split intoAlgebra.Order.Group.Unbundled.AbsandAlgebra.Order.Group.Absto separate the bundled and unbundled parts of the file and minimize imports downstream.