[Merged by Bors] - Congruence subgroup namespace#14573
Closed
[Merged by Bors] - Congruence subgroup namespace#14573
Conversation
PR summary 6b053dd002Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Contributor
|
LGTM. I don't know why the bot removed the "blocked by other PR" label, though. Maintainers: please merge this once #14572 is in. maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by loefflerd. |
Member
|
Thanks! bors d+ |
Contributor
|
✌️ CBirkbeck can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
|
Canceled. |
Collaborator
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
Put congruence subgroups into their own namespace, so that things like `Gamma` don't live in the root namespace.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put congruence subgroups into their own namespace, so that things like
Gammadon't live in the root namespace.