[Merged by Bors] - Chore: Rename files with Eisenstein series stuff.#14572
Closed
[Merged by Bors] - Chore: Rename files with Eisenstein series stuff.#14572
Conversation
PR summary c613c3afd3
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.NumberTheory.ModularForms.EisensteinSeries.ModularForm | 1847 | 0 | -1847 (-100.00%) |
| Mathlib.NumberTheory.ModularForms.EisensteinSeries.Basic | 1396 | 1847 | +451 (+32.31%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.NumberTheory.ModularForms.EisensteinSeries.ModularForm |
-1847 |
Mathlib.NumberTheory.ModularForms.EisensteinSeries.Basic |
451 |
Mathlib.NumberTheory.ModularForms.EisensteinSeries.Defs |
1396 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>
1 task
Contributor
|
This seems to be purely a renaming PR, no new code added or removed, and I agree the new names are more sensible maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by loefflerd. |
Contributor
|
(I am assuming that you meant to put an "awaiting-review" tag on this, since you requested a review from Riccardo.) |
Member
|
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
Accidentally created a `Mathlib/NumberTheory/ModularForms/EisensteinSeries/ModularForm.lean` file name. Made it a Basic.lean file and made the previous into a Defs.lean
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidentally created a
Mathlib/NumberTheory/ModularForms/EisensteinSeries/ModularForm.leanfile name. Made it a Basic.lean file and made the previous into a Defs.lean