[Merged by Bors] - feat: generalize Set.inv_mem_center#13921
Closed
Ruben-VandeVelde wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - feat: generalize Set.inv_mem_center#13921Ruben-VandeVelde wants to merge 1 commit intomasterfrom
Ruben-VandeVelde wants to merge 1 commit intomasterfrom
Conversation
From #13034. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
PR summary d742bc1cc3Import changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
4 tasks
grunweg
reviewed
Jun 18, 2024
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Looks straightforward; thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
From #13034. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Contributor
|
Build failed: |
Member
|
bors merge |
Contributor
|
✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
From #13034. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
YaelDillies
reviewed
Jun 18, 2024
Comment on lines
-180
to
+181
| #align set.inv_mem_center Set.inv_mem_center | ||
| #align set.neg_mem_add_center Set.neg_mem_addCenter | ||
| #align set.inv_mem_center Set.inv_mem_centerₓ | ||
| #align set.neg_mem_add_center Set.neg_mem_addCenterₓ |
Contributor
There was a problem hiding this comment.
Really not sure what the point of this is. You're just teaching people porting Lean 3 code that ₓ is noise that is basically never relevant
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
From #13034. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
grunweg
pushed a commit
that referenced
this pull request
Jun 20, 2024
From #13034. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
From #13034. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #13034.
Co-authored-by: Yaël Dillies yael.dillies@gmail.com