[Merged by Bors] - chore: Merge Algebra.Group.Centralizer into Algebra.Group.Center#13034
Closed
YaelDillies wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - chore: Merge Algebra.Group.Centralizer into Algebra.Group.Center#13034YaelDillies wants to merge 3 commits intomasterfrom
Algebra.Group.Centralizer into Algebra.Group.Center#13034YaelDillies wants to merge 3 commits intomasterfrom
Conversation
f269751 to
1a6928d
Compare
|
You can run this locally as follows ## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
0f27710 to
dc3866d
Compare
Contributor
Author
|
Conclusion seems to be that it's fine to merge the files. |
dc3866d to
d98c56a
Compare
PR summary 47b3c1e856
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Group.Centralizer | 230 | 0 | -230 (-100.00%) |
| Mathlib.Algebra.Ring.Centralizer | 235 | 234 | -1 (-0.43%) |
| Mathlib.Algebra.GroupWithZero.Center | 236 | 235 | -1 (-0.42%) |
| Mathlib.GroupTheory.Subsemigroup.Centralizer | 369 | 368 | -1 (-0.27%) |
| Mathlib.Algebra.Star.Center | 537 | 536 | -1 (-0.19%) |
| Mathlib.RingTheory.NonUnitalSubsemiring.Basic | 549 | 548 | -1 (-0.18%) |
| Mathlib.Algebra.Ring.Subsemiring.Basic | 568 | 567 | -1 (-0.18%) |
| Mathlib.Algebra.Ring.CentroidHom | 578 | 577 | -1 (-0.17%) |
Import changes for all files
| Files | Import difference |
|---|---|
| Too many changes (2095)! |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>
Ruben-VandeVelde
added a commit
that referenced
this pull request
Jun 17, 2024
From #13034. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Contributor
|
I think this is doing too much all at once, so I'll split off some changes the coming days |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
From #13034. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
From #13034. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
From #13034. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
From #13034. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
From #13034. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
8df53b3 to
d4121c8
Compare
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
From #13034. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
This PR/issue depends on: |
d4121c8 to
47b3c1e
Compare
Algebra.Group.CenterAlgebra.Group.Centralizer into Algebra.Group.Center
Ruben-VandeVelde
approved these changes
Jul 10, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
lgtm, but I touched this a lot, so please take another look. (Commit by commit might be helpful)
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
…13034) Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Algebra.Group.Centralizer into Algebra.Group.CenterAlgebra.Group.Centralizer into Algebra.Group.Center
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invertible#13030