[Merged by Bors] - chore: distribute fun_prop tagging of measurability lemmas#13869
Closed
[Merged by Bors] - chore: distribute fun_prop tagging of measurability lemmas#13869
Conversation
PR summary fd3fb833adImport changesDependency changes
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
1 task
Collaborator
|
Why didn't you redistribute all the attributes? And didn't remove the file Mathlib/Tactic/FunProp/Measurable.lean ? Otherwise the PR is good with me. |
Contributor
Author
|
Thanks for taking a look! This is the smallest change I needed to make the dependent PR go through. But I'm happy to redistribute the remaining tags also... this might happen only later this week. |
…the respective files So fun_prop can be used without breaking existing assert_not_exists statements.
9a8c353 to
80a5e20
Compare
Also tag Measurable.vadd, which seems fine as well. Question: do I need to specify the attr twice? Documentation is not clear, let's try this in CI.
Was there a reason AEMeasurable.fst and snd were never tagged? I tagged them now...
Contributor
Author
|
I moved the remaining attributes in |
grunweg
commented
Jun 18, 2024
| variable {ι α β γ δ R : Type*} {m0 : MeasurableSpace α} [MeasurableSpace β] [MeasurableSpace γ] | ||
| [MeasurableSpace δ] {f g : α → β} {μ ν : Measure α} | ||
|
|
||
| theorem AEMeasurable.comp_aemeasurable' {f : α → δ} {g : δ → β} (hg : AEMeasurable g (μ.map f)) |
Contributor
Author
There was a problem hiding this comment.
Moved this one to Mathlib/MeasureTheory/Measure/AEMeasurable.lean. Happy to split that into a separate PR, if preferred.
Collaborator
|
Looks good to me! |
| Measurable.aemeasurable | ||
|
|
||
| -- lambda rules: these two are currently missing | ||
| -- attribute [fun_prop] AEMeasurable_apply AEMeasurable_pi |
Contributor
There was a problem hiding this comment.
Can these comments not go next to these lemmas?
Contributor
Author
There was a problem hiding this comment.
For these two lemmas, that's difficult as the lemmas are missing. I moved the other two comments, though - good point, thanks!
Ruben-VandeVelde
approved these changes
Jun 24, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files. (The latter is kept to note two missing statements. It is not imported anywhere any more.) This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files. (The latter is kept to note two missing statements. It is not imported anywhere any more.) This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files. (The latter is kept to note two missing statements. It is not imported anywhere any more.) This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files. (The latter is kept to note two missing statements. It is not imported anywhere any more.) This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files. (The latter is kept to note two missing statements. It is not imported anywhere any more.) This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
into the respective files: essentially dissolves the
FunProp/MeasurableandAEMeasurablefiles.(The latter is kept to note two missing statements. It is not imported anywhere any more.)
This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the
assert_not_existsstatements.Aside. The module docstring for Constructions/BorelSpace/Basic is outdated,
Measurable.addis not mentioned there any more.