Skip to content

[Merged by Bors] - chore: address @[pp_nodot] porting notes#13781

Closed
kmill wants to merge 3 commits intomasterfrom
kmill_ppnodot_porting
Closed

[Merged by Bors] - chore: address @[pp_nodot] porting notes#13781
kmill wants to merge 3 commits intomasterfrom
kmill_ppnodot_porting

Conversation

@kmill
Copy link
Copy Markdown
Contributor

@kmill kmill commented Jun 12, 2024

Adds in @[pp_nodot] wherever there was a porting note, except in some cases where by principle it can never have an affect (such as for MulOpposite.op or SymAlg.sym).

closes #11180


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 12, 2024

PR summary 403173893a

Import changes

No significant changes to the import graph


Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@joneugster joneugster added the porting-notes Mathlib3 to Mathlib4 porting notes. label Jun 18, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 24, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files.
(The latter is kept to note two missing statements. It is not imported anywhere any more.)

This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 24, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 24, 2024
Adds in `@[pp_nodot]` wherever there was a porting note, except in some cases where by principle it can never have an affect (such as for `MulOpposite.op` or `SymAlg.sym`).

closes #11180
mathlib-bors bot pushed a commit that referenced this pull request Jun 24, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files.
(The latter is kept to note two missing statements. It is not imported anywhere any more.)

This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 24, 2024

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Jun 24, 2024
Adds in `@[pp_nodot]` wherever there was a porting note, except in some cases where by principle it can never have an affect (such as for `MulOpposite.op` or `SymAlg.sym`).

closes #11180
mathlib-bors bot pushed a commit that referenced this pull request Jun 24, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files.
(The latter is kept to note two missing statements. It is not imported anywhere any more.)

This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: address @[pp_nodot] porting notes [Merged by Bors] - chore: address @[pp_nodot] porting notes Jun 24, 2024
@mathlib-bors mathlib-bors bot closed this Jun 24, 2024
@mathlib-bors mathlib-bors bot deleted the kmill_ppnodot_porting branch June 24, 2024 12:36
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
Adds in `@[pp_nodot]` wherever there was a porting note, except in some cases where by principle it can never have an affect (such as for `MulOpposite.op` or `SymAlg.sym`).

closes #11180
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files.
(The latter is kept to note two missing statements. It is not imported anywhere any more.)

This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
Adds in `@[pp_nodot]` wherever there was a porting note, except in some cases where by principle it can never have an affect (such as for `MulOpposite.op` or `SymAlg.sym`).

closes #11180
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files.
(The latter is kept to note two missing statements. It is not imported anywhere any more.)

This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Porting note: removed @[pp_nodot]

3 participants