[Merged by Bors] - chore(Data/Fin/Tuple/Basic): Fill in the API hole (partly)#13568
Closed
YaelDillies wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - chore(Data/Fin/Tuple/Basic): Fill in the API hole (partly)#13568YaelDillies wants to merge 2 commits intomasterfrom
YaelDillies wants to merge 2 commits intomasterfrom
Conversation
4 tasks
|
This PR/issue depends on: |
0a77e11 to
e6677cc
Compare
PR summary cd19a39d7fImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
b-mehta
reviewed
Jun 24, 2024
eric-wieser
reviewed
Jul 11, 2024
eric-wieser
reviewed
Jul 11, 2024
As explained by the module doc, we are missing the `Fin.succAbove` equivalent of `Fin.tail`/`Fin.init`. In fact, it already exists as the second projection of `extractNth`, so this PR deletes `extractNth` and defines its second projection as a new function `removeNth`.
cee648d to
cd19a39
Compare
Member
|
bors merge Thanks! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
As explained by the module doc, we are missing the `Fin.succAbove` equivalent of `Fin.tail`/`Fin.init`. In fact, it already exists as the second projection of `extractNth`, so this PR deletes `extractNth` and defines its second projection as a new function `removeNth`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained by the module doc, we are missing the
Fin.succAboveequivalent ofFin.tail/Fin.init. In fact, it already exists as the second projection ofextractNth, so this PR deletesextractNthand defines its second projection as a new functionremoveNth.