[Merged by Bors] - doc(Data/Fin/Tuple/Basic): Compare start/end/middle addition of an entry in module doc#13567
Closed
YaelDillies wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - doc(Data/Fin/Tuple/Basic): Compare start/end/middle addition of an entry in module doc#13567YaelDillies wants to merge 3 commits intomasterfrom
YaelDillies wants to merge 3 commits intomasterfrom
Conversation
…e doc Definitions around adding an entry to a `Fin`-indexed tuple are a mess. This PR documents the mess so that it's easier to fix in a later PR.
eric-wieser
reviewed
Jun 6, 2024
This was referenced Jun 6, 2024
eric-wieser
reviewed
Jun 6, 2024
Contributor
Author
|
Do you think I should update the docstrings of the corresponding declarations to include information similar to what I'm putting in the module doc? |
Member
|
This is helpful, thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
…try in module doc (#13567) Definitions around adding an entry to a `Fin`-indexed tuple are a mess. This PR documents the mess so that it's easier to fix in a later PR.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
…try in module doc (#13567) Definitions around adding an entry to a `Fin`-indexed tuple are a mess. This PR documents the mess so that it's easier to fix in a later PR.
grunweg
pushed a commit
that referenced
this pull request
Jun 20, 2024
…try in module doc (#13567) Definitions around adding an entry to a `Fin`-indexed tuple are a mess. This PR documents the mess so that it's easier to fix in a later PR.
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
…try in module doc (#13567) Definitions around adding an entry to a `Fin`-indexed tuple are a mess. This PR documents the mess so that it's easier to fix in a later PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definitions around adding an entry to a
Fin-indexed tuple are a mess. This PR documents the mess so that it's easier to fix in a later PR.