[Merged by Bors] - chore: add induction_eliminator, cases_eliminator to WithTop etc#13264
Closed
[Merged by Bors] - chore: add induction_eliminator, cases_eliminator to WithTop etc#13264
induction_eliminator, cases_eliminator to WithTop etc#13264Conversation
Add `@[elab_as_elim, induction_eliminator, cases_eliminator]` to - `WithBot.recBotCoe` (added `cases_eliminator`) - `WithTop.recTopCoe` (added `cases_eliminator`) - `ENNReal.recTopCoe` - `ENat.recTopCoe` - `EReal.rec`
2 tasks
Member
Author
|
|
Member
I think this is #13128? |
Member
Author
Indeed, you're right! Thank you! There are too many open PRs at the moment, hard to keep track... |
eric-wieser
approved these changes
May 27, 2024
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors merge
Looking again this doesn't overlap with #13128 after all.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
induction_eliminator, cases_eliminator to WithTop etcinduction_eliminator, cases_eliminator to WithTop etc
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 30, 2024
These are no longer needed after #13264
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
These are no longer needed after #13264
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
@[elab_as_elim, induction_eliminator, cases_eliminator]toWithOne.recOneCoe(addedcases_eliminator)WithZero.recZeroCoe(addedcases_eliminator)ENNReal.recTopCoeENat.recTopCoeEReal.recMostly cherry-picked from #12605
Co-authored-by: @negiizhao