[Merged by Bors] - chore: deprecate bad lemmas about WithTop/WithBot#13128
Closed
eric-wieser wants to merge 11 commits intomasterfrom
Closed
[Merged by Bors] - chore: deprecate bad lemmas about WithTop/WithBot#13128eric-wieser wants to merge 11 commits intomasterfrom
eric-wieser wants to merge 11 commits intomasterfrom
Conversation
Contributor
|
Does |
Contributor
|
Let me mark this as awaiting-author, to reflect its apparent current state. |
Member
Author
|
|
Member
|
Thanks! 🎉 |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 1, 2024
`Order/WithBot.lean` seems to frequently confuse `WithBot.some` and `Option.some`, and some of the lemmas are strange as a result. By teaching `cases` not to introduce `Option.some`, we no longer need these weird lemmas. This deprecates: * `List.maximum_eq_none` → `List.maximum_eq_bot` * `List.minimum_eq_none` → `List.maximum_eq_top` * `WithBot.some_le_some` → `WithBot.coe_le_coe` * `WithBot.some_lt_some` → `WithBot.coe_lt_coe` * `WithBot.none_lt_some` → `WithBot.bot_lt_coe` * `WithBot.not_lt_none` → `WithBot.not_lt_bot` * `WithBot.none_le` → `bot_le` * `WithTop.some_le_some` → `WithTop.coe_le_coe` * `WithTop.some_lt_some` → `WithTop.coe_lt_coe` * `WithTop.some_lt_none` → `WithTop.coe_lt_top` * `WithTop.not_none_lt` → `WithTop.not_top_lt` * `WithTop.le_none` → `le_top` It's still occasionally possible to end up with `Option.some a : WithTop A`, but when this happens you can rewrite by `some_eq_coe` first to fix it.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
`Order/WithBot.lean` seems to frequently confuse `WithBot.some` and `Option.some`, and some of the lemmas are strange as a result. By teaching `cases` not to introduce `Option.some`, we no longer need these weird lemmas. This deprecates: * `List.maximum_eq_none` → `List.maximum_eq_bot` * `List.minimum_eq_none` → `List.maximum_eq_top` * `WithBot.some_le_some` → `WithBot.coe_le_coe` * `WithBot.some_lt_some` → `WithBot.coe_lt_coe` * `WithBot.none_lt_some` → `WithBot.bot_lt_coe` * `WithBot.not_lt_none` → `WithBot.not_lt_bot` * `WithBot.none_le` → `bot_le` * `WithTop.some_le_some` → `WithTop.coe_le_coe` * `WithTop.some_lt_some` → `WithTop.coe_lt_coe` * `WithTop.some_lt_none` → `WithTop.coe_lt_top` * `WithTop.not_none_lt` → `WithTop.not_top_lt` * `WithTop.le_none` → `le_top` It's still occasionally possible to end up with `Option.some a : WithTop A`, but when this happens you can rewrite by `some_eq_coe` first to fix it.
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
`Order/WithBot.lean` seems to frequently confuse `WithBot.some` and `Option.some`, and some of the lemmas are strange as a result. By teaching `cases` not to introduce `Option.some`, we no longer need these weird lemmas. This deprecates: * `List.maximum_eq_none` → `List.maximum_eq_bot` * `List.minimum_eq_none` → `List.maximum_eq_top` * `WithBot.some_le_some` → `WithBot.coe_le_coe` * `WithBot.some_lt_some` → `WithBot.coe_lt_coe` * `WithBot.none_lt_some` → `WithBot.bot_lt_coe` * `WithBot.not_lt_none` → `WithBot.not_lt_bot` * `WithBot.none_le` → `bot_le` * `WithTop.some_le_some` → `WithTop.coe_le_coe` * `WithTop.some_lt_some` → `WithTop.coe_lt_coe` * `WithTop.some_lt_none` → `WithTop.coe_lt_top` * `WithTop.not_none_lt` → `WithTop.not_top_lt` * `WithTop.le_none` → `le_top` It's still occasionally possible to end up with `Option.some a : WithTop A`, but when this happens you can rewrite by `some_eq_coe` first to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Order/WithBot.leanseems to frequently confuseWithBot.someandOption.some, and some of the lemmas are strange as a result.By teaching
casesnot to introduceOption.some, we no longer need these weird lemmas.This deprecates:
List.maximum_eq_none→List.maximum_eq_botList.minimum_eq_none→List.maximum_eq_topWithBot.some_le_some→WithBot.coe_le_coeWithBot.some_lt_some→WithBot.coe_lt_coeWithBot.none_lt_some→WithBot.bot_lt_coeWithBot.not_lt_none→WithBot.not_lt_botWithBot.none_le→bot_leWithTop.some_le_some→WithTop.coe_le_coeWithTop.some_lt_some→WithTop.coe_lt_coeWithTop.some_lt_none→WithTop.coe_lt_topWithTop.not_none_lt→WithTop.not_top_ltWithTop.le_none→le_topIt's still occasionally possible to end up with
Option.some a : WithTop A, but when this happens you can rewrite bysome_eq_coefirst to fix it.