[Merged by Bors] - chore: Move ring power lemmas earlier#12818
Closed
YaelDillies wants to merge 10 commits intomasterfrom
Closed
[Merged by Bors] - chore: Move ring power lemmas earlier#12818YaelDillies wants to merge 10 commits intomasterfrom
YaelDillies wants to merge 10 commits intomasterfrom
Conversation
Move a bunch of `pow` lemmas from `Algebra.Group.Commute.Defs` and `Algebra.GroupPower.Basic` to `Algebra.Group.Defs` and `Algebra.Group.Basic` with little to no changes to their proofs.
After #12736, `powMonoidHom` and `zpowGroupHom` can move to `Algebra.Group.Hom.Basic` at no cost. This PR moves them and deletes the now empty `Algebra.GroupPower.Hom`.
After #12817, almost all lemmas can move from `Algebra.GroupPower.Ring` to earlier files at no cost. The few remaining lemmas could also move, but it would require a tiny bit more work.
|
This PR/issue depends on:
|
Ruben-VandeVelde
approved these changes
May 15, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Vierkantor
approved these changes
May 16, 2024
Contributor
Vierkantor
left a comment
There was a problem hiding this comment.
Thanks! Not sure why I didn't notice this on the maintainer merge queue.
bors merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 16, 2024
After #12817, almost all lemmas can move from `Algebra.GroupPower.Ring` to earlier files at no cost. The few remaining lemmas could also move, but it would require a tiny bit more work.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
After #12817, almost all lemmas can move from `Algebra.GroupPower.Ring` to earlier files at no cost. The few remaining lemmas could also move, but it would require a tiny bit more work.
grunweg
pushed a commit
that referenced
this pull request
May 17, 2024
After #12817, almost all lemmas can move from `Algebra.GroupPower.Ring` to earlier files at no cost. The few remaining lemmas could also move, but it would require a tiny bit more work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #12817, almost all lemmas can move from
Algebra.GroupPower.Ringto earlier files at no cost.The few remaining lemmas could also move, but it would require a tiny bit more work.
Algebra.GroupPower.Hom#12817