Skip to content

[Merged by Bors] - chore: Delete Algebra.GroupPower.Hom#12817

Closed
YaelDillies wants to merge 6 commits intomasterfrom
delete_group_power_hom
Closed

[Merged by Bors] - chore: Delete Algebra.GroupPower.Hom#12817
YaelDillies wants to merge 6 commits intomasterfrom
delete_group_power_hom

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented May 11, 2024

After #12736, powMonoidHom and zpowGroupHom can move to Algebra.Group.Hom.Basic at no cost. This PR moves them and deletes the now empty Algebra.GroupPower.Hom.


Open in Gitpod

Move a bunch of `pow` lemmas from `Algebra.Group.Commute.Defs` and `Algebra.GroupPower.Basic` to `Algebra.Group.Defs` and `Algebra.Group.Basic` with little to no changes to their proofs.
After #12736, `powMonoidHom` and `zpowGroupHom` can move to `Algebra.Group.Hom.Basic` at no cost. This PR moves them and deletes the now empty `Algebra.GroupPower.Hom`.
@YaelDillies YaelDillies added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) awaiting-review t-algebra Algebra (groups, rings, fields, etc) labels May 11, 2024
@YaelDillies YaelDillies requested a review from Vierkantor May 11, 2024 09:25
YaelDillies added a commit that referenced this pull request May 11, 2024
After #12817, almost all lemmas can move from `Algebra.GroupPower.Ring` to earlier files at no cost.

The few remaining lemmas could also move, but it would require a tiny bit more work.
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 13, 2024
@ghost
Copy link
Copy Markdown

ghost commented May 13, 2024

This PR/issue depends on:

Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 13, 2024
After #12736, `powMonoidHom` and `zpowGroupHom` can move to `Algebra.Group.Hom.Basic` at no cost. This PR moves them and deletes the now empty `Algebra.GroupPower.Hom`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Delete Algebra.GroupPower.Hom [Merged by Bors] - chore: Delete Algebra.GroupPower.Hom May 13, 2024
@mathlib-bors mathlib-bors bot closed this May 13, 2024
@mathlib-bors mathlib-bors bot deleted the delete_group_power_hom branch May 13, 2024 15:49
mathlib-bors bot pushed a commit that referenced this pull request May 16, 2024
After #12817, almost all lemmas can move from `Algebra.GroupPower.Ring` to earlier files at no cost.

The few remaining lemmas could also move, but it would require a tiny bit more work.
callesonne pushed a commit that referenced this pull request May 16, 2024
After #12736, `powMonoidHom` and `zpowGroupHom` can move to `Algebra.Group.Hom.Basic` at no cost. This PR moves them and deletes the now empty `Algebra.GroupPower.Hom`.
callesonne pushed a commit that referenced this pull request May 16, 2024
After #12817, almost all lemmas can move from `Algebra.GroupPower.Ring` to earlier files at no cost.

The few remaining lemmas could also move, but it would require a tiny bit more work.
grunweg pushed a commit that referenced this pull request May 17, 2024
After #12736, `powMonoidHom` and `zpowGroupHom` can move to `Algebra.Group.Hom.Basic` at no cost. This PR moves them and deletes the now empty `Algebra.GroupPower.Hom`.
grunweg pushed a commit that referenced this pull request May 17, 2024
After #12817, almost all lemmas can move from `Algebra.GroupPower.Ring` to earlier files at no cost.

The few remaining lemmas could also move, but it would require a tiny bit more work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants