Skip to content

[Merged by Bors] - feat(Topology/Algebra/InfiniteSum/Order): Add tprod_subtype_le#12600

Closed
CBirkbeck wants to merge 2 commits intomasterfrom
tprod_subtype_le
Closed

[Merged by Bors] - feat(Topology/Algebra/InfiniteSum/Order): Add tprod_subtype_le#12600
CBirkbeck wants to merge 2 commits intomasterfrom
tprod_subtype_le

Conversation

@CBirkbeck
Copy link
Copy Markdown
Collaborator

We add a lemma that says the tprod/tsum over a subtype is less than the full sum. Needed for #12456


Open in Gitpod

Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

#align tsum_le_tsum_of_inj tsum_le_tsum_of_inj

@[to_additive]
lemma tprod_subtype_le {κ γ : Type*} [OrderedCommGroup γ] [UniformSpace γ] [UniformGroup γ]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there no variables that you can reuse?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So annoyingly I couldn't figure out how to do this as α above is the closest thing, but its a monoid not a group, and when I try adding the OrderedCommGroup instance, things break.

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels May 5, 2024
@CBirkbeck CBirkbeck added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels May 7, 2024
@Ruben-VandeVelde
Copy link
Copy Markdown
Contributor

Thanks for checking.

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 27, 2024
@dupuisf
Copy link
Copy Markdown
Contributor

dupuisf commented May 28, 2024

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 28, 2024
We add a lemma that says the tprod/tsum over a subtype is less than the full sum. Needed for #12456
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/Algebra/InfiniteSum/Order): Add tprod_subtype_le [Merged by Bors] - feat(Topology/Algebra/InfiniteSum/Order): Add tprod_subtype_le May 28, 2024
@mathlib-bors mathlib-bors bot closed this May 28, 2024
@mathlib-bors mathlib-bors bot deleted the tprod_subtype_le branch May 28, 2024 01:14
callesonne pushed a commit that referenced this pull request Jun 4, 2024
We add a lemma that says the tprod/tsum over a subtype is less than the full sum. Needed for #12456
js2357 pushed a commit that referenced this pull request Jun 18, 2024
We add a lemma that says the tprod/tsum over a subtype is less than the full sum. Needed for #12456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants