Skip to content

[Merged by Bors] - Eisenstein series are bounded at infinity#12456

Closed
CBirkbeck wants to merge 212 commits intomasterfrom
eisensteinSeries_bounded_at_infty
Closed

[Merged by Bors] - Eisenstein series are bounded at infinity#12456
CBirkbeck wants to merge 212 commits intomasterfrom
eisensteinSeries_bounded_at_infty

Conversation

@CBirkbeck
Copy link
Copy Markdown
Collaborator

@CBirkbeck CBirkbeck commented Apr 26, 2024

CBirkbeck and others added 30 commits February 6, 2024 17:48
…mposition.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…mposition.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
callesonne pushed a commit that referenced this pull request Jun 4, 2024
We add a lemma that says the tprod/tsum over a subtype is less than the full sum. Needed for #12456
callesonne pushed a commit that referenced this pull request Jun 4, 2024
…12601)

Add some basic results about `ModularGroup.T` relating to slash invariant forms of level Gamma(N) and moving elements into verticalStrips. Needed for #12456
 


Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Jun 11, 2024
@CBirkbeck CBirkbeck added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Jun 16, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 16, 2024

PR summary 6fb0dc1fb8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.NumberTheory.ModularForms.EisensteinSeries.IsBoundedAtImInfty 1497

Declarations diff

+ abs_le_tsum_abs
+ eisensteinSeries_SIF_apply
+ isBoundedAtImInfty_eisensteinSeries_SIF
+ summable_norm_eisSummand

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

js2357 pushed a commit that referenced this pull request Jun 18, 2024
We add a lemma that says the tprod/tsum over a subtype is less than the full sum. Needed for #12456
js2357 pushed a commit that referenced this pull request Jun 18, 2024
…12601)

Add some basic results about `ModularGroup.T` relating to slash invariant forms of level Gamma(N) and moving elements into verticalStrips. Needed for #12456
 


Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
@hrmacbeth
Copy link
Copy Markdown
Member

hrmacbeth commented Jul 2, 2024

Have you considered using z ^ (-k) rather than 1 / z ^ k in the eisSummand definition? It seems to make the algebra a bit shorter: diff

@CBirkbeck
Copy link
Copy Markdown
Collaborator Author

CBirkbeck commented Jul 3, 2024

Have you considered using z ^ (-k) rather than 1 / z ^ k in the eisSummand definition? It seems to make the algebra a bit shorter: diff

Oh I didnt think of that, I didn't know if would this significant a change, but I'm happy with it. Is there an easy way to merge your suggestions into the PR? NVM I think I figured it out.

@CBirkbeck CBirkbeck requested a review from riccardobrasca July 7, 2024 17:36
Copy link
Copy Markdown
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 8, 2024

✌️ CBirkbeck can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@CBirkbeck
Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 8, 2024
We show the `IsBoundedAtImInfty`  property for Eisenstein series.



Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 8, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title Eisenstein series are bounded at infinity [Merged by Bors] - Eisenstein series are bounded at infinity Jul 8, 2024
@mathlib-bors mathlib-bors bot closed this Jul 8, 2024
@mathlib-bors mathlib-bors bot deleted the eisensteinSeries_bounded_at_infty branch July 8, 2024 13:15
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants