[Merged by Bors] - chore: Move monoid with zero instances on pi types#12286
Closed
YaelDillies wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - chore: Move monoid with zero instances on pi types#12286YaelDillies wants to merge 3 commits intomasterfrom
YaelDillies wants to merge 3 commits intomasterfrom
Conversation
Closed
3 tasks
YaelDillies
commented
Apr 20, 2024
| theorem moment_zero (hp : p ≠ 0) : moment 0 p μ = 0 := by | ||
| simp only [moment, hp, zero_pow, Ne, not_false_iff, Pi.zero_apply, integral_const, | ||
| smul_eq_mul, mul_zero] | ||
| smul_eq_mul, mul_zero, integral_zero] |
Contributor
Author
There was a problem hiding this comment.
No idea why this was needed
Member
|
Can you split the |
Contributor
Author
|
See #12317 |
Move everything that can't be additivised out of `Algebra.Group.Pi.Lemmas`: * `MulZeroClass`, `MulZeroOneClass`, etc... instances go to a new `Algebra.GroupWithZero.Pi` file. I credit Eric W. for leanprover-community/mathlib3#4766. * `AddMonoidWithOne`, `AddGroupWithOne` instances go to `Algebra.Ring.Pi`.
b725124 to
bc66dc9
Compare
eric-wieser
reviewed
Apr 21, 2024
eric-wieser
reviewed
Apr 21, 2024
Vierkantor
approved these changes
Apr 29, 2024
Contributor
Vierkantor
left a comment
There was a problem hiding this comment.
Looks good to me otherwise!
bors d+
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
Move everything that can't be additivised out of `Algebra.Group.Pi.Lemmas`: * `MulZeroClass`, `MulZeroOneClass`, etc... instances go to a new `Algebra.GroupWithZero.Pi` file. I credit Eric W. for leanprover-community/mathlib3#4766. * `AddMonoidWithOne`, `AddGroupWithOne` instances go to `Algebra.Ring.Pi`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
Move everything that can't be additivised out of `Algebra.Group.Pi.Lemmas`: * `MulZeroClass`, `MulZeroOneClass`, etc... instances go to a new `Algebra.GroupWithZero.Pi` file. I credit Eric W. for leanprover-community/mathlib3#4766. * `AddMonoidWithOne`, `AddGroupWithOne` instances go to `Algebra.Ring.Pi`.
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
Move everything that can't be additivised out of `Algebra.Group.Pi.Lemmas`: * `MulZeroClass`, `MulZeroOneClass`, etc... instances go to a new `Algebra.GroupWithZero.Pi` file. I credit Eric W. for leanprover-community/mathlib3#4766. * `AddMonoidWithOne`, `AddGroupWithOne` instances go to `Algebra.Ring.Pi`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move everything that can't be additivised out of
Algebra.Group.Pi.Lemmas:MulZeroClass,MulZeroOneClass, etc... instances go to a newAlgebra.GroupWithZero.Pifile. I credit Eric W. for [Merged by Bors] - feat(algebra, logic): Pi instances for nontrivial and monoid_with_zero mathlib3#4766.AddMonoidWithOne,AddGroupWithOneinstances go toAlgebra.Ring.Pi.