[Merged by Bors] - chore: Rename a few lemmas about Pi.mulSingle#12317
Closed
YaelDillies wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - chore: Rename a few lemmas about Pi.mulSingle#12317YaelDillies wants to merge 1 commit intomasterfrom
Pi.mulSingle#12317YaelDillies wants to merge 1 commit intomasterfrom
Conversation
These were erroneously named after `Pi.single`.
Member
|
bors d+ I don't think this was an error, I think it was a decision at the time which turned out to become inconsistent later. I've edited the description accordingly; please merge if you're ok with it. |
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
|
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 21, 2024
Before this PR, the `MonoidHom` version of `Pi.mulSingle` was called `MonoidHom.single` for brevity; but this is confusing when contrasted with `MulHom.single` which is about `Pi.single`. After this PR, the name is `MonoidHom.mulSingle`. Also fix the name of `Pi.single_div` since it is about `Pi.mulSingle` (and we don't have the lemma that would be called `Pi.single_div`).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Pi.mulSinglePi.mulSingle
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Before this PR, the `MonoidHom` version of `Pi.mulSingle` was called `MonoidHom.single` for brevity; but this is confusing when contrasted with `MulHom.single` which is about `Pi.single`. After this PR, the name is `MonoidHom.mulSingle`. Also fix the name of `Pi.single_div` since it is about `Pi.mulSingle` (and we don't have the lemma that would be called `Pi.single_div`).
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
Before this PR, the `MonoidHom` version of `Pi.mulSingle` was called `MonoidHom.single` for brevity; but this is confusing when contrasted with `MulHom.single` which is about `Pi.single`. After this PR, the name is `MonoidHom.mulSingle`. Also fix the name of `Pi.single_div` since it is about `Pi.mulSingle` (and we don't have the lemma that would be called `Pi.single_div`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, the
MonoidHomversion ofPi.mulSinglewas calledMonoidHom.singlefor brevity; but this is confusing when contrasted withMulHom.singlewhich is aboutPi.single.After this PR, the name is
MonoidHom.mulSingle.Also fix the name of
Pi.single_divsince it is aboutPi.mulSingle(and we don't have the lemma that would be calledPi.single_div).