[Merged by Bors] - ci: Raise Archive build failures#11612
Closed
YaelDillies wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - ci: Raise Archive build failures#11612YaelDillies wants to merge 5 commits intomasterfrom
YaelDillies wants to merge 5 commits intomasterfrom
Conversation
This is fallout from #11530. Somehow CI didn't catch that.
6070244 to
8abbf63
Compare
225d0ba to
33a0eaf
Compare
eric-wieser
approved these changes
Mar 23, 2024
Member
eric-wieser
left a comment
There was a problem hiding this comment.
LGTM
Thoughts, @semorrison?
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 24, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
reviewed
Mar 24, 2024
| # Hopefully a future re-implementation of `cache` will obviate the present need for this hack. | ||
| lake exe cache get Archive.lean | ||
| lake build Archive | tee --append stdout.log | ||
| bash -o pipefail -c "env LEAN_ABORT_ON_PANIC=1 lake build Archive | tee --append stdout.log" |
Member
There was a problem hiding this comment.
I guess in principle we should run the problem-matcher here, but we probably shouldn't give it our secrets
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
CI didn't catch the fallout from #11530 because we forgot to pipe the errors coming from `lake build Archive` and `lake build Counterexamples` back to the logs. This PR makes sure that happens.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
xgenereux
pushed a commit
that referenced
this pull request
Mar 25, 2024
CI didn't catch the fallout from #11530 because we forgot to pipe the errors coming from `lake build Archive` and `lake build Counterexamples` back to the logs. This PR makes sure that happens.
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
CI didn't catch the fallout from #11530 because we forgot to pipe the errors coming from `lake build Archive` and `lake build Counterexamples` back to the logs. This PR makes sure that happens.
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
CI didn't catch the fallout from #11530 because we forgot to pipe the errors coming from `lake build Archive` and `lake build Counterexamples` back to the logs. This PR makes sure that happens.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
CI didn't catch the fallout from #11530 because we forgot to pipe the errors coming from `lake build Archive` and `lake build Counterexamples` back to the logs. This PR makes sure that happens.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
CI didn't catch the fallout from #11530 because we forgot to pipe the errors coming from `lake build Archive` and `lake build Counterexamples` back to the logs. This PR makes sure that happens.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
CI didn't catch the fallout from #11530 because we forgot to pipe the errors coming from `lake build Archive` and `lake build Counterexamples` back to the logs. This PR makes sure that happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI didn't catch the fallout from #11530 because we forgot to pipe the errors coming from
lake build Archiveandlake build Counterexamplesback to the logs. This PR makes sure that happens.