[Merged by Bors] - ci: Import Archive when checking YAML files#11562
Closed
YaelDillies wants to merge 12 commits intomasterfrom
Closed
[Merged by Bors] - ci: Import Archive when checking YAML files#11562YaelDillies wants to merge 12 commits intomasterfrom
Archive when checking YAML files#11562YaelDillies wants to merge 12 commits intomasterfrom
Conversation
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`.
1 task
Member
|
Can you prove this works by updating one of the existing |
Member
|
(no need to do them all in this PR, though that would also be great!) |
d9b95c4 to
f8149ab
Compare
Member
|
bors d+ |
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
reviewed
Mar 23, 2024
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Contributor
|
Build failed (retrying...): |
Contributor
Author
|
bors -r We seem to have hit a difference between CI for PRs and CI for master. |
Contributor
|
Did you mean "r-"? |
Contributor
Author
|
bors r- |
Contributor
|
Canceled. |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Contributor
|
Build failed: |
Member
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 24, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Archive when checking YAML filesArchive when checking YAML files
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in `checkYaml` only imports `Mathlib`. This PR changes it to also import `Archive`. It also changes the hyperlinks to Archive to instead list declarations directly. Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from `lake build Archive` (see #11612). Co-authored-by: Enrico Borba <enricozb@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We sometimes want to refer to Archive declarations in the YAML files. This is currently impossible because the script in
checkYamlonly importsMathlib. This PR changes it to also importArchive.It also changes the hyperlinks to Archive to instead list declarations directly.
Also fix the fallout from #11530 that CI didn't catch that because we forgot to pipe the errors coming from
lake build Archive(see #11612).Co-authored-by: Enrico Borba enricozb@gmail.com