Skip to content

[Merged by Bors] - feat port Data.Nat.Pow#1050

Closed
riccardobrasca wants to merge 8 commits intomasterfrom
RB/data_nat_pow
Closed

[Merged by Bors] - feat port Data.Nat.Pow#1050
riccardobrasca wants to merge 8 commits intomasterfrom
RB/data_nat_pow

Conversation

@riccardobrasca
Copy link
Copy Markdown
Member

@riccardobrasca riccardobrasca commented Dec 15, 2022

aba57d4d3dae35460225919dcd82fe91355162f9

@riccardobrasca riccardobrasca added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Dec 15, 2022
@riccardobrasca riccardobrasca added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) awaiting-review and removed WIP Work in progress labels Dec 15, 2022
@kim-em kim-em removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Dec 15, 2022
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Dec 16, 2022

(No need to include git shas in the PR description anymore.)

Comment on lines +24 to +31
#print Nat.pow_le_pow_of_le_left /-
-- This is redundant with `pow_le_pow_of_le_left'`,
-- We leave a version in the `nat` namespace as well.
-- (The global `pow_le_pow_of_le_left` needs an extra hypothesis `0 ≤ x`.)
protected theorem pow_le_pow_of_le_left {x y : ℕ} (H : x ≤ y) : ∀ i : ℕ, x ^ i ≤ y ^ i :=
pow_le_pow_of_le_left' H
#align nat.pow_le_pow_of_le_left Nat.pow_le_pow_of_le_left
-/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be replaced with just the #align statement. (The lemmas has moved to Std.)

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Dec 16, 2022

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 16, 2022
bors bot pushed a commit that referenced this pull request Dec 16, 2022
aba57d4d3dae35460225919dcd82fe91355162f9

- [x] depends on #1043 

Co-authored-by: Siddhartha Gadgil <siddhartha.gadgil@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Dec 16, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat port Data.Nat.Pow [Merged by Bors] - feat port Data.Nat.Pow Dec 16, 2022
@bors bors bot closed this Dec 16, 2022
@bors bors bot deleted the RB/data_nat_pow branch December 16, 2022 03:25
bors bot pushed a commit that referenced this pull request Dec 19, 2022
aba57d4d3dae35460225919dcd82fe91355162f9

- [x] depends on #1043 
- [x] depends on #1050  

Co-authored-by: Siddhartha Gadgil <siddhartha.gadgil@gmail.com>
bors bot pushed a commit that referenced this pull request Dec 21, 2022
fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e

- [x] depends on #1040  
- [x] depends on #1043
- [x] depends on #1050 
- [x] depends on #1055 

Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
Co-authored-by: Winston Yin <winstonyin@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
bors bot pushed a commit that referenced this pull request Dec 21, 2022
fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e

- [x] depends on #1040  
- [x] depends on #1043
- [x] depends on #1050 
- [x] depends on #1055 

Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
Co-authored-by: Winston Yin <winstonyin@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
bors bot pushed a commit that referenced this pull request Dec 21, 2022
fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e

- [x] depends on #1040  
- [x] depends on #1043
- [x] depends on #1050 
- [x] depends on #1055 

Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
Co-authored-by: Winston Yin <winstonyin@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants