Skip to content

[Merged by Bors] - feat: port Algebra.GroupPower.Order#1043

Closed
siddhartha-gadgil wants to merge 8 commits intomasterfrom
algebra_grouppower_order
Closed

[Merged by Bors] - feat: port Algebra.GroupPower.Order#1043
siddhartha-gadgil wants to merge 8 commits intomasterfrom
algebra_grouppower_order

Conversation

@siddhartha-gadgil
Copy link
Copy Markdown
Collaborator

from fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e

have commented out mono annotations as the corresponding tactic is not yet implemented.

@siddhartha-gadgil siddhartha-gadgil changed the title WIP port Algebra.GroupPower.Order feat: port Algebra.GroupPower.Order Dec 15, 2022
@siddhartha-gadgil siddhartha-gadgil added mathlib-port This is a port of a theory file from mathlib. awaiting-review labels Dec 15, 2022
siddhartha-gadgil and others added 3 commits December 15, 2022 21:50
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
@kim-em kim-em added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Dec 15, 2022
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Dec 15, 2022

have commented out mono annotations as the corresponding tactic is not yet implemented.

Please add a comment with the phrase "Porting note", e.g. "-- Porting note: mono not implemented yet", in the source code, so we can identify these afterwards.

@kim-em kim-em force-pushed the algebra_grouppower_order branch from fcd03f1 to d6c3a71 Compare December 15, 2022 21:53
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Dec 15, 2022

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Dec 15, 2022
bors bot pushed a commit that referenced this pull request Dec 15, 2022
from fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e

have commented out `mono` annotations as the corresponding tactic is not yet implemented.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Dec 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.GroupPower.Order [Merged by Bors] - feat: port Algebra.GroupPower.Order Dec 15, 2022
@bors bors bot closed this Dec 15, 2022
@bors bors bot deleted the algebra_grouppower_order branch December 15, 2022 22:15
bors bot pushed a commit that referenced this pull request Dec 16, 2022
aba57d4d3dae35460225919dcd82fe91355162f9

- [x] depends on #1043 

Co-authored-by: Siddhartha Gadgil <siddhartha.gadgil@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot pushed a commit that referenced this pull request Dec 19, 2022
aba57d4d3dae35460225919dcd82fe91355162f9

- [x] depends on #1043 
- [x] depends on #1050  

Co-authored-by: Siddhartha Gadgil <siddhartha.gadgil@gmail.com>
bors bot pushed a commit that referenced this pull request Dec 21, 2022
fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e

- [x] depends on #1040  
- [x] depends on #1043
- [x] depends on #1050 
- [x] depends on #1055 

Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
Co-authored-by: Winston Yin <winstonyin@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
bors bot pushed a commit that referenced this pull request Dec 21, 2022
fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e

- [x] depends on #1040  
- [x] depends on #1043
- [x] depends on #1050 
- [x] depends on #1055 

Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
Co-authored-by: Winston Yin <winstonyin@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
bors bot pushed a commit that referenced this pull request Dec 21, 2022
fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e

- [x] depends on #1040  
- [x] depends on #1043
- [x] depends on #1050 
- [x] depends on #1055 

Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
Co-authored-by: Winston Yin <winstonyin@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants