This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(data/matrix/basic): add lemmas about dot_product and mul_vec#8325
Closed
eric-wieser wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - chore(data/matrix/basic): add lemmas about dot_product and mul_vec#8325eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser wants to merge 2 commits intomasterfrom
Conversation
This renames: * mul_vec_one` to `one_mul_vec` * mul_vec_zero` to `zero_mul_vec`, and adds the new lemmas: * `sub_mul_vec` * `mul_vec_sub` * `zero_mul_vec` * `mul_vec_zero` * `sub_dot_product` * `dot_product_sub` Some existing lemmas have had their variables extracted to sections. Co-authored-by: l534zhan <luming.zhang@merton.ox.ac.uk>
2 tasks
Collaborator
|
This conflicts with #8303, which is in |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Canceled. |
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2021
…8325) This renames: * `mul_vec_one` to `one_mul_vec` * `mul_vec_zero` to `zero_mul_vec` and adds the new lemmas: * `sub_mul_vec` * `mul_vec_sub` * `zero_mul_vec` * `mul_vec_zero` * `sub_dot_product` * `dot_product_sub` Some existing lemmas have had their variables extracted to sections. Co-authored-by: l534zhan <luming.zhang@merton.ox.ac.uk>
|
Pull request successfully merged into master. Build succeeded: |
b-mehta
pushed a commit
that referenced
this pull request
Jul 20, 2021
…8325) This renames: * `mul_vec_one` to `one_mul_vec` * `mul_vec_zero` to `zero_mul_vec` and adds the new lemmas: * `sub_mul_vec` * `mul_vec_sub` * `zero_mul_vec` * `mul_vec_zero` * `sub_dot_product` * `dot_product_sub` Some existing lemmas have had their variables extracted to sections. Co-authored-by: l534zhan <luming.zhang@merton.ox.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames:
mul_vec_onetoone_mul_vecmul_vec_zerotozero_mul_vecand adds the new lemmas:
sub_mul_vecmul_vec_subzero_mul_vecmul_vec_zerosub_dot_productdot_product_subSome existing lemmas have had their variables extracted to sections.
Co-authored-by: l534zhan luming.zhang@merton.ox.ac.uk
This is partially extracted from #8289