Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - chore(data/matrix/basic): add lemmas about dot_product and mul_vec#8325

Closed
eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser/tidy-vector-lemmas
Closed

[Merged by Bors] - chore(data/matrix/basic): add lemmas about dot_product and mul_vec#8325
eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser/tidy-vector-lemmas

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Jul 15, 2021

This renames:

  • mul_vec_one to one_mul_vec
  • mul_vec_zero to zero_mul_vec

and adds the new lemmas:

  • sub_mul_vec
  • mul_vec_sub
  • zero_mul_vec
  • mul_vec_zero
  • sub_dot_product
  • dot_product_sub

Some existing lemmas have had their variables extracted to sections.

Co-authored-by: l534zhan luming.zhang@merton.ox.ac.uk


Open in Gitpod

This is partially extracted from #8289

This renames:
* mul_vec_one` to `one_mul_vec`
* mul_vec_zero` to `zero_mul_vec`,

and adds the new lemmas:
* `sub_mul_vec`
* `mul_vec_sub`
* `zero_mul_vec`
* `mul_vec_zero`
* `sub_dot_product`
* `dot_product_sub`

Some existing lemmas have had their variables extracted to sections.

Co-authored-by: l534zhan <luming.zhang@merton.ox.ac.uk>
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jul 15, 2021
@eric-wieser eric-wieser requested a review from Vierkantor July 15, 2021 13:20
Copy link
Copy Markdown
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 15, 2021
@bryangingechen
Copy link
Copy Markdown
Collaborator

This conflicts with #8303, which is in staging right now.
bors r-
bors d+

@bors
Copy link
Copy Markdown

bors bot commented Jul 15, 2021

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bors
Copy link
Copy Markdown

bors bot commented Jul 15, 2021

Canceled.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Jul 15, 2021
@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Jul 15, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jul 15, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jul 15, 2021
@eric-wieser
Copy link
Copy Markdown
Member Author

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 16, 2021
bors bot pushed a commit that referenced this pull request Jul 16, 2021
…8325)

This renames:
* `mul_vec_one` to `one_mul_vec`
* `mul_vec_zero` to `zero_mul_vec`

and adds the new lemmas:
* `sub_mul_vec`
* `mul_vec_sub`
* `zero_mul_vec`
* `mul_vec_zero`
* `sub_dot_product`
* `dot_product_sub`

Some existing lemmas have had their variables extracted to sections.

Co-authored-by: l534zhan <luming.zhang@merton.ox.ac.uk>
@bors
Copy link
Copy Markdown

bors bot commented Jul 16, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/matrix/basic): add lemmas about dot_product and mul_vec [Merged by Bors] - chore(data/matrix/basic): add lemmas about dot_product and mul_vec Jul 16, 2021
@bors bors bot closed this Jul 16, 2021
@bors bors bot deleted the eric-wieser/tidy-vector-lemmas branch July 16, 2021 01:33
b-mehta pushed a commit that referenced this pull request Jul 20, 2021
…8325)

This renames:
* `mul_vec_one` to `one_mul_vec`
* `mul_vec_zero` to `zero_mul_vec`

and adds the new lemmas:
* `sub_mul_vec`
* `mul_vec_sub`
* `zero_mul_vec`
* `mul_vec_zero`
* `sub_dot_product`
* `dot_product_sub`

Some existing lemmas have had their variables extracted to sections.

Co-authored-by: l534zhan <luming.zhang@merton.ox.ac.uk>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants