This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(data/matrix/{basic, block}): missing lemmas on conj_transpose#8303
Closed
eric-wieser wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - feat(data/matrix/{basic, block}): missing lemmas on conj_transpose#8303eric-wieser wants to merge 4 commits intomasterfrom
eric-wieser wants to merge 4 commits intomasterfrom
Conversation
This also moves some imports around to make the star operator on vectors available in matrix/basic.lean
2 tasks
39841c0 to
9851ff0
Compare
Vierkantor
reviewed
Jul 15, 2021
Collaborator
Vierkantor
left a comment
There was a problem hiding this comment.
It feels like a number of these could be promoted to simp lemmas. Do you have any good intuition which ones?
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Member
Author
Not really, no - for the |
Vierkantor
approved these changes
Jul 15, 2021
Collaborator
Vierkantor
left a comment
There was a problem hiding this comment.
I went through the files and couldn't find an obvious simp candidate, so let's leave that to a different PR where we have a better opportunity of figuring out the correct normal form.
bors r+
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also moves some imports around to make the star operator on vectors available in matrix/basic.lean
This is a follow up to #8291