This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(algebra/direct_sum): the submodules of an internal direct sum satisfy supr A = ⊤#8274
Closed
eric-wieser wants to merge 6 commits intomasterfrom
Closed
Conversation
…ubmodule}.[d]finsupp_sum_mem` These lemmas are trivial consequences of the finset lemmas, but having them avoids having to unfold `[d]finsupp.sum`. `dfinsupp_sum_add_hom_mem` is particularly useful because this one has some messy decidability arguments to eliminate.
…tisfy `supr A = ⊤`
2 tasks
This comment has been minimized.
This comment has been minimized.
eric-wieser
commented
Jul 12, 2021
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2021
…tisfy `supr A = ⊤` (#8274) The main results here are: * `direct_sum.add_submonoid_is_internal.supr_eq_top` * `direct_sum.submodule_is_internal.supr_eq_top` Which we prove using the new lemmas * `add_submonoid.supr_eq_mrange_dfinsupp_sum_add_hom` * `submodule.supr_eq_range_dfinsupp_lsum` There's no obvious way to reuse the proofs between the two, but thankfully all four proofs are quite short anyway. These should aid in shortening #8246.
|
Pull request successfully merged into master. Build succeeded: |
supr A = ⊤supr A = ⊤
b-mehta
pushed a commit
that referenced
this pull request
Jul 20, 2021
…tisfy `supr A = ⊤` (#8274) The main results here are: * `direct_sum.add_submonoid_is_internal.supr_eq_top` * `direct_sum.submodule_is_internal.supr_eq_top` Which we prove using the new lemmas * `add_submonoid.supr_eq_mrange_dfinsupp_sum_add_hom` * `submodule.supr_eq_range_dfinsupp_lsum` There's no obvious way to reuse the proofs between the two, but thankfully all four proofs are quite short anyway. These should aid in shortening #8246.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main results here are:
direct_sum.add_submonoid_is_internal.supr_eq_topdirect_sum.submodule_is_internal.supr_eq_topWhich we prove using the new lemmas
add_submonoid.supr_eq_mrange_dfinsupp_sum_add_homsubmodule.supr_eq_range_dfinsupp_lsumThere's no obvious way to reuse the proofs between the two, but thankfully all four proofs are quite short anyway.
These should aid in shortening #8246.
{add_submonoid,submodule}.[d]finsupp_sum_mem#8269cc @acxxa