This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat({data,linear_algebra}/{finsupp,dfinsupp}): add {add_submonoid,submodule}.[d]finsupp_sum_mem#8269
Closed
eric-wieser wants to merge 3 commits intomasterfrom
Closed
Conversation
…ubmodule}.[d]finsupp_sum_mem` These lemmas are trivial consequences of the finset lemmas, but having them avoids having to unfold `[d]finsupp.sum`. `dfinsupp_sum_add_hom_mem` is particularly useful because this one has some messy decidability arguments to eliminate.
Vierkantor
approved these changes
Jul 12, 2021
Collaborator
Vierkantor
left a comment
There was a problem hiding this comment.
Looks good to me. There should be a nicer way to get these lemmas also for subalgebra, subring, subfield, intermediate_field, ...
bors r+
bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
…ubmodule}.[d]finsupp_sum_mem` (#8269) These lemmas are trivial consequences of the finset lemmas, but having them avoids having to unfold `[d]finsupp.sum`. `dfinsupp_sum_add_hom_mem` is particularly useful because this one has some messy decidability arguments to eliminate.
Member
Author
|
Indeed - I stopped at submodule because for #8246 we don't really need any more. |
1 task
|
Pull request successfully merged into master. Build succeeded: |
{add_submonoid,submodule}.[d]finsupp_sum_mem{add_submonoid,submodule}.[d]finsupp_sum_mem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These lemmas are trivial consequences of the finset lemmas, but having them avoids having to unfold
[d]finsupp.sum.dfinsupp_sum_add_hom_memis particularly useful because this one has some messy decidability arguments to eliminate.Zulip