Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

chore(.travis.yml): use git clean to clean out untracked files#659

Merged
avigad merged 2 commits intoleanprover-community:masterfrom
leanprover-fork:travis-clean
Jan 30, 2019
Merged

chore(.travis.yml): use git clean to clean out untracked files#659
avigad merged 2 commits intoleanprover-community:masterfrom
leanprover-fork:travis-clean

Conversation

@rwbarton
Copy link
Copy Markdown
Collaborator

PR #641 involved renaming a directory. The old directory was still
present in the cache, and in this situation git status lists the
directory as a whole as untracked, so the grep did not find any
.lean files.

For reviewers: code review check list

PR leanprover-community#641 involved renaming a directory. The old directory was still
present in the cache, and in this situation `git status` lists the
directory as a whole as untracked, so the grep did not find any
`.lean` files.
@rwbarton
Copy link
Copy Markdown
Collaborator Author

Actually this won't work because the old .olean files will be left behind, and Lean will use them...

@rwbarton
Copy link
Copy Markdown
Collaborator Author

@cipher1024 is going to fix this PR, I believe.

@avigad avigad merged commit 829b49b into leanprover-community:master Jan 30, 2019
@cipher1024 cipher1024 deleted the travis-clean branch January 30, 2019 23:20
cipher1024 pushed a commit that referenced this pull request Feb 8, 2019
* chore(.travis.yml): use git clean to clean out untracked files and delete more obsolete olean files

PR #641 involved renaming a directory. The old directory was still
present in the cache, and in this situation `git status` lists the
directory as a whole as untracked, so the grep did not find any
`.lean` files.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants